Skip to content

Fix Quick Chat phrase search contrast #6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DawsonCodes wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −1
Open

Fix Quick Chat phrase search contrast #6427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48b63c0
Fix Quick Chat phrase search contrast
DawsonCodes Nov 14, 2026
9896bdb
Fix Quick Chat player search contrast
DawsonCodes Nov 14, 2026
ee26cb1
Revert Quick Chat player search changes
DawsonCodes Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/hud/layers/ChatModal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export class ChatModal extends LitElement {
${
this.showAll
? html`<input
class="px-2 py-1.5 rounded-md bg-zinc-800 ring-1 ring-white/10 text-sm outline-none focus:ring-white/30"
class="px-2 py-1.5 rounded-md bg-zinc-800 text-white ring-1 ring-white/10 text-sm outline-none focus:ring-white/30"
type="text"
placeholder=${translateText("chat.search_phrases")}
.value=${this.phraseSearch}
Expand Down
8 changes: 8 additions & 0 deletions tests/client/ChatModal.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,14 @@ describe("ChatModal", () => {
expect(sectionTitles("Recent")).toEqual(["GG!"]);
});

it("uses light text in the dark phrase search field", async () => {
allPhrasesSwitch().click();
await modal.updateComplete;

const search = modal.querySelector("input");
expect(search?.classList.contains("text-white")).toBe(true);
});

it("searches all phrases by their text once all phrases are on", async () => {
expect(modal.querySelector("input")).toBeNull();
chip("GG!").click();
Expand Down
Loading