[jcking]

Ensure the compiler cannot optimize the copy loops by replacing them with memcpy which is allowed to copy byte by byte potentially introducing tearing. Currently there is nothing preventing the compiler from doing this. We add volatile which prevents the compiler from making this optimization in the future.

Currently the code generates to ldp and stp, this change does have the side affect of forcing it to do ldr and str. If that seems unacceptable from a performance standpoint we can hand-roll assembly to do ldp and stp.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8369207: Copy_conjoint{jshorts,jints,jlongs}_atomic on Linux/BSD AArch64 do not prevent tearing (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27647/head:pull/27647
$ git checkout pull/27647

Update a local copy of the PR:
$ git checkout pull/27647
$ git pull https://git.openjdk.org/jdk.git pull/27647/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27647

View PR using the GUI difftool:
$ git pr show -t 27647

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27647.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@jcking The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e3e0cb0a)

[theRealAph]

Currently the code generates to ldp and stp, this change does have the side affect of forcing it to do ldr and str. If that seems unacceptable from a performance standpoint we can hand-roll assembly to do ldp and stp.

That would be much better.

[jcking]

Currently the code generates to ldp and stp, this change does have the side affect of forcing it to do ldr and str. If that seems unacceptable from a performance standpoint we can hand-roll assembly to do ldp and stp.

That would be much better.

#27642 is already going to move it to ldr and str, FYI.

[jcking]

Moving this back to draft until discussions in #27642 finish.

[bridgekeeper]

@jcking This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@jcking This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.