[dev-jonghoonpark]

Changes

• PLABStats has atomic data members (_allocated, _wasted, _undo_wasted, _unused) with protected access. After JDK-8375971, the derived G1EvacStats accesses these via accessor functions rather than directly, so they can now be made private.
• _description remains protected as it is still directly accessed by G1EvacStats.

Test

• Verified that make images completes without errors.
• Confirmed that Tier1 tests pass successfully.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8378128: Make PLABStats data members private (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29982/head:pull/29982
$ git checkout pull/29982

Update a local copy of the PR:
$ git checkout pull/29982
$ git pull https://git.openjdk.org/jdk.git pull/29982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29982

View PR using the GUI difftool:
$ git pr show -t 29982

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29982.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dev-jonghoonpark! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dev-jonghoonpark This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8378128: Make PLABStats data members private

Reviewed-by: tschatzl, ayang, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 2adffe0: 8378872: Mark waitList in FetcherInfo final
• 2678fe4: 8378870: Remove sun.awt.AWTAccessor from imports in ImageIcon
• 2c3e4f0: 8378595: Refactor miscellaneous tests under test/jdk/java/net/httpclient from TestNG to JUnit
• ... and 11 more: https://git.openjdk.org/jdk/compare/f3d7ca33d797c3475a4c31d612e7ed8f71d1f5b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @albertnetymk, @TheShermanTanker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@dev-jonghoonpark The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (41db5e1b)

[dev-jonghoonpark]

/integrate

[openjdk]

@dev-jonghoonpark
Your change (at version 41db5e1) is now ready to be sponsored by a Committer.

[TheShermanTanker]

You should wait for 2 Reviews in HotSpot code before running integrate, but since this has been approved twice already, I'll sponsor.

[TheShermanTanker]

/sponsor

[openjdk]

Going to push as commit cc4ca9f.
Since your change was applied there have been 14 commits pushed to the master branch:

• 2adffe0: 8378872: Mark waitList in FetcherInfo final
• 2678fe4: 8378870: Remove sun.awt.AWTAccessor from imports in ImageIcon
• 2c3e4f0: 8378595: Refactor miscellaneous tests under test/jdk/java/net/httpclient from TestNG to JUnit
• ... and 11 more: https://git.openjdk.org/jdk/compare/f3d7ca33d797c3475a4c31d612e7ed8f71d1f5b0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker @dev-jonghoonpark Pushed as commit cc4ca9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dev-jonghoonpark]

You should wait for 2 Reviews in HotSpot code before running integrate

I wasn't aware of that part. I'll be more careful next time. Thank you for letting me know.