[dev-jonghoonpark]

changes

Cleanup unused is_shareable and log_to_classlist declarations from InstanceKlass.hpp

Test

• Verified that make images completes without errors.
• Confirmed that Tier1 tests pass successfully.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8382312: Cleanup instanceKlass dead code (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30810/head:pull/30810
$ git checkout pull/30810

Update a local copy of the PR:
$ git checkout pull/30810
$ git pull https://git.openjdk.org/jdk.git pull/30810/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30810

View PR using the GUI difftool:
$ git pr show -t 30810

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30810.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dev-jonghoonpark! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dev-jonghoonpark This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382312: Cleanup instanceKlass dead code

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 35f623b: 8382090: Remove .rej and .orig from .gitignore
• 8d79d47: 8382391: Cleanup unnecessary storestore() in stringStream::as_string
• 35b0de3: 8382043: Add missing @OverRide annotations in "javax.print.attribute" package
• ... and 1 more: https://git.openjdk.org/jdk/compare/0dd0108c1a7b3658df536adbc2bd68fa5167539d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@dev-jonghoonpark The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 00: Full (5ea101b8)

[dholmes-ora]

This is trivially fine to me. Dropping reviewers to 1.

/reviewers 1

[openjdk]

@dholmes-ora
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

[dev-jonghoonpark]

/integrate
Thank you for the review.

[openjdk]

@dev-jonghoonpark
Your change (at version 5ea101b) is now ready to be sponsored by a Committer.

[dholmes-ora]

/sponsor

[openjdk]

Going to push as commit 444e6f6.
Since your change was applied there have been 4 commits pushed to the master branch:

• 35f623b: 8382090: Remove .rej and .orig from .gitignore
• 8d79d47: 8382391: Cleanup unnecessary storestore() in stringStream::as_string
• 35b0de3: 8382043: Add missing @OverRide annotations in "javax.print.attribute" package
• ... and 1 more: https://git.openjdk.org/jdk/compare/0dd0108c1a7b3658df536adbc2bd68fa5167539d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora @dev-jonghoonpark Pushed as commit 444e6f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.