[dev-jonghoonpark]

Changes

• Fixed missing Ideal optimization opportunity for ConvL2I
  • ConvL2INode::Ideal folds ConvL2I(AndL(x, 0xFFFFFFFF)) to ConvL2I(x), but the ConvL2I was not revisited when the AndL mask became 0xFFFFFFFF during IGVN.
  • Push the ConvL2I users of an AndL when an input of the AndL changes.
• Added the reproducer attached to JBS as a regression test (compiler/igvn/TestConvL2INodeIdeal.java)

Test

• Verified that make images completes without errors.
• Confirmed that Tier1 tests pass successfully.
• Confirmed that Regression test pass successfully.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8392942: C2: Missed Ideal optimization opportunity for ConvL2I (Bug - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Marc Chevalier (@marc-chevalier - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/33194/head:pull/33194
$ git checkout pull/33194

Update a local copy of the PR:
$ git checkout pull/33194
$ git pull https://git.openjdk.org/jdk.git pull/33194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33194

View PR using the GUI difftool:
$ git pr show -t 33194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/33194.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dev-jonghoonpark! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dev-jonghoonpark This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8392942: C2: Missed Ideal optimization opportunity for ConvL2I

Reviewed-by: chagedorn, mchevalier, ayang

You can use pull request commands such as /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

• 8e48fff: 8377548: Implement dark theme for other specs and tool guides
• 850620f: 8393706: [windows] DefaultProxySelector.c loop continues after proxy_array was set to NULL
• 118ef3b: 8393866: C2: TypeInstPtr with klass_is_exact should not have abstract instance_klass
• ... and 79 more: https://git.openjdk.org/jdk/compare/f3701c80216900f3ded26f9de1befe43813be95c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @marc-chevalier, @albertnetymk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@dev-jonghoonpark The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 02: Full - Incremental (a0ed9907)
• 01: Full - Incremental (0101ed81)
• 00: Full (83f3be82)

[chhagedorn]

Looks good, thanks!

[marc-chevalier]

Looks good, we can spare one flag I think.

[marc-chevalier]

Thanks for the change! I'm rerunning test, but I'm optimistic it should be as fine as before.

[chhagedorn]

Still good!

[marc-chevalier]

Tests look good.

[dev-jonghoonpark]

/integrate

[openjdk]

@dev-jonghoonpark
Your change (at version a0ed990) is now ready to be sponsored by a Committer.

[marc-chevalier]

/sponsor

[openjdk]

Going to push as commit cfff6bf.
Since your change was applied there have been 82 commits pushed to the master branch:

• 8e48fff: 8377548: Implement dark theme for other specs and tool guides
• 850620f: 8393706: [windows] DefaultProxySelector.c loop continues after proxy_array was set to NULL
• 118ef3b: 8393866: C2: TypeInstPtr with klass_is_exact should not have abstract instance_klass
• ... and 79 more: https://git.openjdk.org/jdk/compare/f3701c80216900f3ded26f9de1befe43813be95c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@marc-chevalier @dev-jonghoonpark Pushed as commit cfff6bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.