Overlap detection for plotter#3969
Open
viktormai wants to merge 26 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds overlap detection support to the slice data API, enabling
the OpenMC plotter to identify and display which specific cells are
overlapping at a given pixel.
Changes
of a simple boolean, containing a list of OverlapKey pairs (cell1_id,
cell2_id, universe_id) for each detected overlap
pair data during raster plot generation
of overlapping cell pairs at a given pixel
overlapping cell IDs and universe ID at a given pixel
Previously the plotter could color overlap pixels but had no way to tell
the user which cells were overlapping. This change stores the overlap
pair data during plot generation so the plotter can display meaningful
overlap information when a user hovers over an overlap pixel.
Checklist