Skip to content

add exit_worker_by* feature - #1682

Merged
rainingmaster merged 22 commits into
openresty:masterfrom
rainingmaster:exit_worker
Jul 23, 2020
Merged

rainingmaster merged 22 commits into
openresty:masterfrom
rainingmaster:exit_worker

Conversation

@rainingmaster

@rainingmaster rainingmaster commented Apr 3, 2020 •

Copy link
Copy Markdown
Member

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.

The continue for #927 , and add some new test cases.

@thibaultcha @doujiang24 Could you help me check it? Thank you.

And this is the change for lua-resty-core: rainingmaster/lua-resty-core@c787d7d

@thibaultcha

Copy link
Copy Markdown
Member

Thanks! For the time being, we are focusing our efforts on the upcoming releases (1.15.8.3 and 1.17.8.1); at least I am - so it may take us some time to review this for now.

Comment thread README.markdown Resolved
Comment thread src/ngx_http_lua_exitworkerby.c Resolved
@rainingmaster

Copy link
Copy Markdown
Member Author

Thanks! For the time being, we are focusing our efforts on the upcoming releases (1.15.8.3 and 1.17.8.1); at least I am - so it may take us some time to review this for now.

It does not matter, I just follow some advice in Q2 like here said

Comment thread doc/HttpLuaModule.wiki Resolved
Comment thread doc/HttpLuaModule.wiki Resolved
Comment thread doc/HttpLuaModule.wiki Resolved
Comment thread src/ngx_http_lua_exitworkerby.c Resolved
Comment thread src/ngx_http_lua_exitworkerby.c Resolved
Comment thread t/162-exit-worker.t Resolved
Comment thread t/162-exit-worker.t Resolved
Comment thread t/162-exit-worker.t Resolved
Comment thread src/ngx_http_lua_util.h Resolved
Comment thread src/ngx_http_lua_exitworkerby.c Resolved
@rainingmaster

Copy link
Copy Markdown
Member Author

@thibaultcha Most review is resolve, could you help me check again, thanks a lot.

Comment thread README.markdown Resolved
Comment thread README.markdown Resolved
Comment thread src/ngx_http_lua_exitworkerby.c Resolved
@agentzh

agentzh commented Jun 26, 2020

Copy link
Copy Markdown
Member

Guys, is this PR ready for merge?

@agentzh

agentzh commented Jun 27, 2020

Copy link
Copy Markdown
Member

One thing that is still missing is we should enable APIs which are available in init_worker_by_lua except the timer API? The docs need updating to reflect this.

@rainingmaster

rainingmaster commented Jun 28, 2020 •

Copy link
Copy Markdown
Member Author

One thing that is still missing is we should enable APIs which are available in init_worker_by_lua except the timer API? The docs need updating to reflect this.

@agentzh Thanks for your review. I have updated the doc to reflect which APIs are available in exit_worker_by_lua, and both ngx.timer.run_count and ngx.timer.pending_count are marked.

@rainingmaster

Copy link
Copy Markdown
Member Author

@agentzh @doujiang24 hihi, since 1.17.8 is released, could we merge this PR now?

Comment thread README.markdown Resolved
Comment thread README.markdown Resolved
Comment thread README.markdown Resolved
@rainingmaster
rainingmaster merged commit 393c954 into openresty:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants