Skip to content

bugfix: added the missing 'ngx.req.start_time' to the stream subsystem. - #306

Merged
doujiang24 merged 1 commit into
openresty:masterfrom
thibaultcha:fix/stream-req-start-time
Jul 30, 2020
Merged

doujiang24 merged 1 commit into
openresty:masterfrom
thibaultcha:fix/stream-req-start-time

Conversation

@thibaultcha

Copy link
Copy Markdown
Member

The ngx.req.start_time() API is part of request.lua which is was
understandably not loaded for the stream subsystem. There existed no
tests for this API in the stream subsystem, so the removal of its
underlying CFunction resulted in ngx.req.start_time being nil with
no test cases to realize that.

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-resty-core project.

The `ngx.req.start_time()` API is part of `request.lua` which is was
understandably not loaded for the stream subsystem. There existed no
tests for this API in the stream subsystem, so the removal of its
underlying CFunction resulted in `ngx.req.start_time` being `nil` with
no test cases to realize it.
@spacewander

Copy link
Copy Markdown
Member

We need a way to document which APIs are enabled in stream subsystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants