Repository navigation
bugfix: added the missing 'ngx.req.start_time' to the stream subsystem. - #306
Merged
doujiang24 merged 1 commit intoJul 30, 2020
Merged
Conversation
The `ngx.req.start_time()` API is part of `request.lua` which is was understandably not loaded for the stream subsystem. There existed no tests for this API in the stream subsystem, so the removal of its underlying CFunction resulted in `ngx.req.start_time` being `nil` with no test cases to realize it.
spacewander
approved these changes
Jul 14, 2020
Member
|
We need a way to document which APIs are enabled in stream subsystem. |
doujiang24
approved these changes
Jul 18, 2020
agentzh
approved these changes
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ngx.req.start_time()API is part ofrequest.luawhich is wasunderstandably not loaded for the stream subsystem. There existed no
tests for this API in the stream subsystem, so the removal of its
underlying CFunction resulted in
ngx.req.start_timebeingnilwithno test cases to realize that.