Do not source a file from /tmp - #1957
Merged
openshift-merge-bot[bot] merged 1 commit intoSep 4, 2026
Merged
Conversation
Sourcing files from a world-writeable location as root isn't a great security practice. We don't expect anyone to run dev-scripts on a multi-user system, but let's still fix it. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Member
Author
|
/retest |
Contributor
|
/lgtm |
Member
Author
|
/cc @andfasano @bfournie PTAL for approval, this change may have broader impact |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
/retest-required |
2 similar comments
Contributor
|
/retest-required |
Member
Author
|
/retest-required |
openshift-merge-bot
Bot
merged commit Sep 4, 2026
e70cc29
into
openshift-metal3:master
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcing files from a world-writeable location as root isn't a great
security practice. We don't expect anyone to run dev-scripts on a
multi-user system, but let's still fix it.
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com