Adopt all relevant parts of metal3-dev-env and drop dependency - #1960
Adopt all relevant parts of metal3-dev-env and drop dependency#1960dtantsur wants to merge 4 commits into
Conversation
The initial idea was that we'd stay pretty close to metal3-dev-env. This is not the case. OpenShift works very differently from upstream Metal3, and our dev-scripts have grown a number of deviations from dev-env. The pinned hash requires regular updates. We use an older Ansible version. Go installation logic gets in the way all the time because of unstable mirrors. On top of this, upstream Metal3 community wants to gradually phase out metal3-dev-env in favour of leaner development scripts in CAPM3 and BMO. With this change, I've tasked Claude to transfer all relevant parts of dev-scripts and drop any hacks around upstream metal3-dev-env. Most of the code concerns creating testing VMs. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
|
/hold This is a proof of concept |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
do-not-merge/hold
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
|
@dtantsur: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 participant
The initial idea was that we'd stay pretty close to metal3-dev-env. This
is not the case. OpenShift works very differently from upstream Metal3,
and our dev-scripts have grown a number of deviations from dev-env.
The pinned hash requires regular updates. We use an older Ansible
version. Go installation logic gets in the way all the time because of
unstable mirrors.
On top of this, upstream Metal3 community wants to gradually phase out
metal3-dev-env in favour of leaner development scripts in CAPM3 and BMO.
With this change, I've tasked Claude to transfer all relevant parts of
dev-scripts and drop any hacks around upstream metal3-dev-env. Most of
the code concerns creating testing VMs.
Further commits clean up irrelevant parts of the transferred code, such as
support for Ubuntu/Suse or our hacks.
Metal3-dev-env commit was c963d687d23c6a2e1f024359415680606de157ff
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com