OCPBUGS-94869: fix(crd): adjust storage settings for CRIOCredentialProviderConfig

[QiWang19]

Fix: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-upgrade-rhcos9-techpreview/2071854856083083264

• OCPNODE-4125: Introduce to v1 CRIOCredentialProviderConfig #2725 (OCPNODE-4125: Introduce to v1 CRIOCredentialProviderConfig by QiWang19 · Pull Request #2725 · openshift/api ) (merged June 25, commit c85beac) modified the payload CRD manifest (payload-manifests/crds/0000_10_config-operator_01_criocredentialproviderconfigs.crd.yaml) to:
  Add v1 with storage: true
  Change v1alpha1 from storage: true to storage: false.

Although once all consumers migrate to v1, v1alpha1 goes away completely, during migration, we need to keep storage version as v1alpha1 for the CI to pass.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @QiWang19! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request changes the storage version designation for the CRIOCredentialProviderConfig custom resource definition. In the manual-override manifest, a v1 version entry is added with storage: false, and the served version's storage flag is set to true. Correspondingly, in the generated payload CRD manifest, the v1 stanza's storage flag is set to false while the v1alpha1 stanza's storage flag is set to true, effectively designating v1alpha1 as the storage version.

Changes

File	Change Summary
config/v1/manual-override-crd-manifests/criocredentialproviderconfigs.config.openshift.io/CRIOCredentialProviderConfig.yaml	Added v1 version entry with storage: false; changed served version storage flag from false to true
payload-manifests/crds/0000_10_config-operator_01_criocredentialproviderconfigs.crd.yaml	Changed v1 storage flag from true to false; changed v1alpha1 storage flag from false to true

Sequence Diagram(s)

Not applicable; this change is limited to CRD manifest configuration flags and does not involve an observable runtime flow.

Estimated code review effort: 2 (Simple)

Related issues: None found

Related PRs: None found

Suggested labels: api-review, crd-schema-change

Suggested reviewers: None found

---

🐰 A hop, a flip, a version swap,
Storage flags go flippity-flop,
v1alpha1 now holds the crown,
While v1 quietly settles down,
A tiny YAML, a carrot-sized change! 🥕

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only CRD YAML manifests were changed; no Ginkgo test files or titles were added or modified.
Test Structure And Quality	✅ Passed	No Ginkgo tests were touched; the PR only updates CRD YAML manifests, so this checklist is not applicable.
Microshift Test Compatibility	✅ Passed	PR only updates CRD YAML manifests; no new Ginkgo e2e tests or MicroShift-unsupported APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Manifest-only CRD storage-version changes; no new Ginkgo e2e tests or SNO-sensitive node assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only CRD version/storage fields changed; no deployment, controller, affinity, nodeSelector, toleration, or topology-spread settings were introduced.
Ote Binary Stdout Contract	✅ Passed	PR only updates CRD YAML manifests for CRIOCredentialProviderConfig; no process-level code or stdout writes are introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only CRD YAML manifests changed; no Ginkgo test code or IPv4/external-connectivity logic was added.
No-Weak-Crypto	✅ Passed	PASS: Touched files are CRD/type manifests only; targeted search found no MD5/SHA1/DES/RC4/etc. or secret comparisons.
Container-Privileges	✅ Passed	The changed manifests are CRDs only; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields are present.
No-Sensitive-Data-In-Logs	✅ Passed	Only CRD storage-version YAML changed; no logger/printf/log statements were added, and sensitive-string hits are schema docs, not logs.
Title check	✅ Passed	The title clearly and concisely summarizes the CRD storage-version change for CRIOCredentialProviderConfig.
Description check	✅ Passed	The description clearly matches the CRD storage-version fix for CRIOCredentialProviderConfig and the CI issue it addresses.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[QiWang19]

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-upgrade-rhcos9-techpreview 2

[openshift-ci]

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-upgrade-rhcos9-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2a85a0d0-7639-11f1-866c-ccb7daa31a10-0

[openshift-ci-robot]

@QiWang19: This pull request references Jira Issue OCPBUGS-94869, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fix: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-upgrade-rhcos9-techpreview/2071854856083083264

• OCPNODE-4125: Introduce to v1 CRIOCredentialProviderConfig #2725 (OCPNODE-4125: Introduce to v1 CRIOCredentialProviderConfig by QiWang19 · Pull Request #2725 · openshift/api ) (merged June 25, commit c85beac) modified the payload CRD manifest (payload-manifests/crds/0000_10_config-operator_01_criocredentialproviderconfigs.crd.yaml) to:
  Add v1 with storage: true
  Change v1alpha1 from storage: true to storage: false.

Although once all consumers migrate to v1, v1alpha1 goes away completely, during migration to keep storage version as v1alpha1 for to keep ci pass.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[QiWang19]

/jira refresh

[openshift-ci-robot]

@QiWang19: This pull request references Jira Issue OCPBUGS-94869, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[QiWang19]

/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci-robot]

@QiWang19: This pull request references Jira Issue OCPBUGS-94869, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Fix: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-upgrade-rhcos9-techpreview/2071854856083083264

• OCPNODE-4125: Introduce to v1 CRIOCredentialProviderConfig #2725 (OCPNODE-4125: Introduce to v1 CRIOCredentialProviderConfig by QiWang19 · Pull Request #2725 · openshift/api ) (merged June 25, commit c85beac) modified the payload CRD manifest (payload-manifests/crds/0000_10_config-operator_01_criocredentialproviderconfigs.crd.yaml) to:
  Add v1 with storage: true
  Change v1alpha1 from storage: true to storage: false.

Although once all consumers migrate to v1, v1alpha1 goes away completely, during migration, we need to keep storage version as v1alpha1 for the CI to pass.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[QiWang19]

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-upgrade-rhcos9-techpreview 2

https://prow.ci.openshift.org/?job=openshift-api-2913*
payload jobs passed

[QiWang19]

/verified by payload-jobs

[openshift-ci-robot]

@QiWang19: This PR has been marked as verified by payload-jobs.

Details

In response to this:

/verified by payload-jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/lgtm

[openshift-merge-bot]

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/retest

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD ef71f94 and 2 for PR HEAD 9f503bc in total

[openshift-ci]

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@QiWang19: Jira Issue Verification Checks: Jira Issue OCPBUGS-94869
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-94869 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Fix: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-upgrade-rhcos9-techpreview/2071854856083083264

• OCPNODE-4125: Introduce to v1 CRIOCredentialProviderConfig #2725 (OCPNODE-4125: Introduce to v1 CRIOCredentialProviderConfig by QiWang19 · Pull Request #2725 · openshift/api ) (merged June 25, commit c85beac) modified the payload CRD manifest (payload-manifests/crds/0000_10_config-operator_01_criocredentialproviderconfigs.crd.yaml) to:
  Add v1 with storage: true
  Change v1alpha1 from storage: true to storage: false.

Although once all consumers migrate to v1, v1alpha1 goes away completely, during migration, we need to keep storage version as v1alpha1 for the CI to pass.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.