OCPBUGS-86875: Always use RHUI icons by logonoff · Pull Request #16528 · openshift/console

logonoff · 2026-06-02T16:10:44Z

Analysis / Root cause:

Per the PatternFly community meeting:

Upstream: Use the Default (blue) PatternFly theme, the generic backgrounds, and Red Hat icons. Glass mode is optional.

Red Hat Products: Use the Project Felt theme, generic product or product-specific (both brand-approved) images for backgrounds, and Red Hat icons. Glass mode is optional but encouraged.

Currently upstream (OKD) uses font awesome and Red Hat (OpenShift) uses RH icons.

Solution description:

Before:

4.22: font awesome
OKD: font awesome
OpenShift: RHUI

After:

4.22: RHUI
OKD: RHUI
OpenShift: RHUI

Screenshots / screen recording:

Test cases:

Icons should match the "after" case

Browser conformance:

Chrome
Firefox
Safari (or Epiphany on Linux)

Additional info:

Summary by CodeRabbit

Style
- Updated HTML styling class application for improved UI theme and icon set handling, reorganizing how styling classes are applied to enhance rendering consistency.

Before: - 4.22: font awesome - OKD: font awesome - OpenShift: RHUI After: - 4.22: RHUI - OKD: RHUI - OpenShift: RHUI

openshift-ci-robot · 2026-06-02T16:10:53Z

@logonoff: This pull request references Jira Issue OCPBUGS-86875, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:

Per the PatternFly community meeting:

Upstream: Use the Default (blue) PatternFly theme, the generic backgrounds, and Red Hat icons. Glass mode is optional.

Red Hat Products: Use the Project Felt theme, generic product or product-specific (both brand-approved) images for backgrounds, and Red Hat icons. Glass mode is optional but encouraged.

Currently upstream (OKD) uses font awesome and Red Hat (OpenShift) uses RH icons.

Solution description:

Before:

4.22: font awesome

OKD: font awesome

OpenShift: RHUI

After:

4.22: RHUI

OKD: RHUI

OpenShift: RHUI

Screenshots / screen recording:

Test cases:

Icons should match the "after" case

Browser conformance:

Chrome

Firefox

Safari (or Epiphany on Linux)

Additional info:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-02T16:11:04Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0f7e5f5e-d592-48b1-9e9c-8d78641d12c7

📥 Commits

Reviewing files that changed from the base of the PR and between 07a33c7 and 9e6a54f.

📒 Files selected for processing (1)

frontend/public/index.html

Walkthrough

The PR reorganizes how PatternFly theme and icon set CSS classes are applied. The pf-v6-icon-set-rh-ui class moves from being added dynamically by the inline script to being declared statically in the root <html> element's class attribute. The script then applies only pf-v6-theme-felt dynamically.

Changes

Icon Set Class Reorganization

Layer / File(s)	Summary
CSS class application reorganization `frontend/public/index.html`	The root `<html>` element gains `pf-v6-icon-set-rh-ui` as a static class, while the inline script is simplified to add only `pf-v6-theme-felt` dynamically, decoupling icon set initialization from theme application logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: ensuring RHUI icons are always used across all builds (4.22, OKD, and OpenShift).
Description check	✅ Passed	The description provides analysis, solution details with before/after comparison, test cases, and browser conformance. Minor sections like screenshots and test setup are understandably not applicable for an icon set change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Custom check for Ginkgo test names is not applicable. PR only modifies frontend/public/index.html (HTML file) with no Go test changes, and repository uses standard Go testing, not Ginkgo.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test code quality is not applicable; PR modifies only frontend/public/index.html (HTML markup), not test code. Ginkgo is a Go testing framework; this is a frontend change.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added in this PR. The PR modifies frontend HTML (icon set CSS classes) and adds Go unit tests using standard Go testing package (not Ginkgo). The check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only modifies frontend UI icon styling (RHUI icons in index.html); no new Ginkgo e2e tests are added, making the check not applicable to this frontend-only change.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only modifies frontend/public/index.html (CSS icon set and theme classes). No deployment manifests, operator code, controllers, or topology-aware scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	This PR modifies only frontend HTML to change icon sets. The OTE Binary Stdout Contract check applies exclusively to Go test process-level code, not frontend HTML templates.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only modifies frontend HTML/icon styling with no new Ginkgo e2e tests added. The check applies only when new Ginkgo tests are added, which is not applicable here.
No-Weak-Crypto	✅ Passed	PR changes only frontend HTML/CSS icon set configuration. No weak cryptography (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or non-constant-time comparisons found.
Container-Privileges	✅ Passed	PR contains no privileged container configs. Test fixtures properly use restrictive security contexts with allowPrivilegeEscalation: false and runAsNonRoot: true.
No-Sensitive-Data-In-Logs	✅ Passed	No logging statements with sensitive data found. The PR only modifies HTML/CSS theming classes and localStorage access, with no console logging or PII exposure.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-06-02T16:11:39Z

@logonoff: This pull request references Jira Issue OCPBUGS-86875, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Analysis / Root cause:

Per the PatternFly community meeting:

Upstream: Use the Default (blue) PatternFly theme, the generic backgrounds, and Red Hat icons. Glass mode is optional.

Red Hat Products: Use the Project Felt theme, generic product or product-specific (both brand-approved) images for backgrounds, and Red Hat icons. Glass mode is optional but encouraged.

Currently upstream (OKD) uses font awesome and Red Hat (OpenShift) uses RH icons.

Solution description:

Before:

4.22: font awesome

OKD: font awesome

OpenShift: RHUI

After:

4.22: RHUI

OKD: RHUI

OpenShift: RHUI

Screenshots / screen recording:

Test cases:

Icons should match the "after" case

Browser conformance:

Chrome

Firefox

Safari (or Epiphany on Linux)

Additional info:

Summary by CodeRabbit

Style

Updated HTML styling class application for improved UI theme and icon set handling, reorganizing how styling classes are applied to enhance rendering consistency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sg00dwin

/lgtm

openshift-ci · 2026-06-02T20:40:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logonoff · 2026-06-02T21:15:23Z

/verified by @logonoff

openshift-ci-robot · 2026-06-02T21:15:36Z

@logonoff: This PR has been marked as verified by @logonoff.

Details

In response to this:

/verified by @logonoff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-06-02T22:08:34Z

/retest-required

Remaining retests: 0 against base HEAD 07a33c7 and 2 for PR HEAD 9e6a54f in total

logonoff · 2026-06-02T23:24:56Z

/test all

openshift-merge-bot · 2026-06-03T04:07:55Z

/retest-required

Remaining retests: 0 against base HEAD 7edff60 and 1 for PR HEAD 9e6a54f in total

openshift-ci · 2026-06-03T06:55:37Z

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-06-03T07:00:57Z

@logonoff: Jira Issue Verification Checks: Jira Issue OCPBUGS-86875
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-86875 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Analysis / Root cause:

Per the PatternFly community meeting:

Upstream: Use the Default (blue) PatternFly theme, the generic backgrounds, and Red Hat icons. Glass mode is optional.

Red Hat Products: Use the Project Felt theme, generic product or product-specific (both brand-approved) images for backgrounds, and Red Hat icons. Glass mode is optional but encouraged.

Currently upstream (OKD) uses font awesome and Red Hat (OpenShift) uses RH icons.

Solution description:

Before:

4.22: font awesome

OKD: font awesome

OpenShift: RHUI

After:

4.22: RHUI

OKD: RHUI

OpenShift: RHUI

Screenshots / screen recording:

Test cases:

Icons should match the "after" case

Browser conformance:

Chrome

Firefox

Safari (or Epiphany on Linux)

Additional info:

Summary by CodeRabbit

Style

Updated HTML styling class application for improved UI theme and icon set handling, reorganizing how styling classes are applied to enhance rendering consistency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-06-06T15:56:56Z

Fix included in release 5.0.0-0.nightly-2026-06-06-100407

OCPBUGS-86875: Always use RHUI icons

9e6a54f

Before: - 4.22: font awesome - OKD: font awesome - OpenShift: RHUI After: - 4.22: RHUI - OKD: RHUI - OpenShift: RHUI

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 2, 2026

openshift-ci Bot requested review from rhamilto and spadgett June 2, 2026 16:16

openshift-ci Bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 2, 2026

sg00dwin approved these changes Jun 2, 2026

View reviewed changes

openshift-ci Bot assigned sg00dwin Jun 2, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 2, 2026

openshift-merge-bot Bot merged commit aa82017 into openshift:main Jun 3, 2026
9 checks passed

logonoff deleted the OCPBUGS-86875-okd-rhicon branch June 3, 2026 09:08

coderabbitai Bot mentioned this pull request Jun 11, 2026

OCPBUGS-87969: Directly use RhUi icons where possible #16591

Merged

Conversation

logonoff commented Jun 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jun 2, 2026

Uh oh!

coderabbitai Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci-robot commented Jun 2, 2026

Summary by CodeRabbit

Uh oh!

sg00dwin left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jun 2, 2026

Uh oh!

logonoff commented Jun 2, 2026

Uh oh!

openshift-ci-robot commented Jun 2, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 2, 2026

Uh oh!

logonoff commented Jun 2, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 3, 2026

Uh oh!

openshift-ci Bot commented Jun 3, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 3, 2026

Summary by CodeRabbit

Uh oh!

openshift-merge-robot commented Jun 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

logonoff commented Jun 2, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 2, 2026 •

edited

Loading