OCPBUGS-87930, OCPBUGS-87982: Bump protobufjs and shell-quote

[matzew]

Bump libraries

[openshift-ci-robot]

@matzew: This pull request references Jira Issue OCPBUGS-87933, which is invalid:

• expected the vulnerability to target either version "5.0." or "openshift-5.0.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add yarn resolutions for protobufjs (7.5.6) and shell-quote (^1.8.4) to address arbitrary code execution via unsafe expression generation from crafted protobuf descriptors.

Analysis / Root cause:

Solution description:

Screenshots / screen recording:

Test setup:

Test cases:

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The PR updates the resolutions block in frontend/package.json to add explicit version overrides for shell-quote and protobufjs; the existing minimatch resolution remains unchanged.

Changes

Dependency Resolution Configuration

Layer / File(s)	Summary
Dependency resolution overrides frontend/package.json	The resolutions block adds explicit version constraints for shell-quote and protobufjs to enforce specific dependency versions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

• rhamilto
• TheRealJon

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is a single-line summary lacking required template sections (analysis, solution, tests, browser conformance, etc.).	Fill in all required PR template sections: analysis/root cause, solution description, test setup, test cases, and browser conformance checkboxes.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR contains no Ginkgo tests. The codebase uses standard Go testing (*testing.T), not Ginkgo, making this check not applicable.
Test Structure And Quality	✅ Passed	PR only modifies frontend/package.json and yarn.lock for dependency updates; no Ginkgo test files present or modified. Check is not applicable to this dependency management PR.
Microshift Test Compatibility	✅ Passed	This PR only modifies frontend/package.json (dependency resolution overrides). No Ginkgo e2e tests are being added or modified, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR contains no new Ginkgo e2e tests. Changes are only to frontend/package.json dependencies (protobufjs, shell-quote). SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only frontend/package.json (dependency versions). Check applies only to deployment manifests, operator code, or controllers. No scheduling constraints or topology assumptions present.
Ote Binary Stdout Contract	✅ Passed	OTE Binary Stdout Contract applies to Go test binaries with stdout violations. This PR only modifies frontend/package.json (JavaScript dependencies), not any Go code or test suite code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR—only dependency updates to frontend/package.json for protobufjs and shell-quote CVE fixes. Check is not applicable.
No-Weak-Crypto	✅ Passed	PR only modifies package.json dependency version pins; no cryptographic code or weak crypto patterns introduced.
Container-Privileges	✅ Passed	PR updates frontend dependencies for CVE fixes. No privileged containers, hostPID/Network/IPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation flags found in modified Dockerfiles or YAML files.
No-Sensitive-Data-In-Logs	✅ Passed	The PR modifies frontend/package.json to update dependency resolutions (protobufjs 7.5.8 and shell-quote 1.8.4). No new logging code that exposes sensitive data is introduced.
Title check	✅ Passed	The title clearly references the main change: bumping protobufjs and shell-quote versions to address security vulnerabilities (OCPBUGS-87930, OCPBUGS-87982), which matches the PR's primary objective.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@frontend/package.json`:
- Line 339: Replace the caret range for the dependency "shell-quote" in
package.json with an exact version string (change "^1.8.4" to "1.8.4") and then
regenerate the lockfile (npm/yarn) so the exact resolved version is recorded;
also verify/update integrity/hash entries in package-lock.json or yarn.lock if
your package manager supports it to satisfy the supply-chain requirement.
- Around line 339-340: Update the protobufjs dependency in package.json from
"protobufjs": "7.5.6" to at least "7.5.8" (so it no longer falls into the
CVE-2026-45740 affected range), then regenerate the lockfile by running the
project's package manager install (npm install or yarn install) so
package-lock.json / yarn.lock is updated; verify package.json entry "protobufjs"
and the lockfile reflect 7.5.8+ and commit both changes.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ca96afaa-245e-4225-a9f1-ca350ea1b0dd

📥 Commits

Reviewing files that changed from the base of the PR and between d7aca4b and 986dc89.

⛔ Files ignored due to path filters (1)

• frontend/yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (1)

• frontend/package.json

[matzew]

/jira refresh

[openshift-ci-robot]

@matzew: This pull request references Jira Issue OCPBUGS-87933, which is invalid:

• expected the vulnerability to target either version "5.0." or "openshift-5.0.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@matzew: This pull request references Jira Issue OCPBUGS-87930, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump protobufjs to 7.5.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@matzew: This pull request references Jira Issue OCPBUGS-87930, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-87982, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump protobufjs to 7.5.6

Summary by CodeRabbit

• Chores
• Added explicit version overrides for internal dependencies to maintain consistency and stability across the project.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@matzew: This pull request references Jira Issue OCPBUGS-87930, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-87982, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Bump libraries

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[matzew]

/cherry-pick release-4.22

[openshift-cherrypick-robot]

@matzew: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Leo6Leo]

PR review tracking + Prowpy retest monitoring
/assign @Leo6Leo

[matzew]

/retest e2e-playwright

[matzew]

/test e2e-playwright

[matzew]

/test e2e-playwright

[Leo6Leo]

/lgtm
/verified by CI

getting approve labels
/assign @logonoff @jhadvig

[openshift-ci-robot]

@Leo6Leo: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/verified by CI

getting approve labels
/assign @logonoff @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Leo6Leo]

protobufjs 6→7 major version jump, but since it only affects Cypress test tooling (not production code) and CI passes, it's safe to merge so it should be fine imo

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, logonoff, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Leo6Leo]

The e2e-playwright failure is not related to this PR at all

[Leo6Leo]

/retest-required

[openshift-ci]

@matzew: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-playwright	a63ed70	link	false	/test e2e-playwright

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.