Skip to content

Adding aarch64 instance types for azure - #6531

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
kelbrown20:new-file-for-aarch64-instance-types
Nov 30, 2022
Merged

Adding aarch64 instance types for azure#6531
openshift-merge-robot merged 1 commit into
openshift:masterfrom
kelbrown20:new-file-for-aarch64-instance-types

Conversation

@kelbrown20

@kelbrown20 kelbrown20 commented Oct 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

For version: 4.12+

Description: Created a new file to use in the "Tested instance types section" for Azure. An example of the formating can be found in modules/installation-aws-tested-machine-types.adoc
OSDOCS-3329

Note: There are likely more instance types that need to be added here

@Prashanth684 Can you PTAL at this PR when you get the chance? Thank you!

@kelbrown20 kelbrown20 changed the title Adding aarch64 instance types for azure [WIP] Adding aarch64 instance types for azure Oct 27, 2022
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2022
@openshift-ci
openshift-ci Bot requested review from jhixson74 and m1kola October 27, 2022 18:12
Prashanth684
Prashanth684 reviewed Oct 27, 2022
View reviewed changes
Comment thread docs/user/azure/tested_instance_types_aarch64.md Outdated
@kelbrown20
kelbrown20 force-pushed the new-file-for-aarch64-instance-types branch from 43e33c3 to a9fb16d Compare November 3, 2022 14:25
@kelbrown20

kelbrown20 commented Nov 3, 2022

Copy link
Copy Markdown
Contributor Author

@MayXuQQ @yunjiang29 @aleskandro Can you PTAL at these new aarch64 instance type file for Azure when you get the chance? Thank you!

@MayXuQQ

MayXuQQ commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

@lwan-wanglin whether all the instance type have been verified on arm ? thanks

@lwan-wanglin

lwan-wanglin commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

@lwan-wanglin whether all the instance type have been verified on arm ? thanks

Thanks @MayXuQQ , we only verified one instance type on arm now, will launch jobs to verify all instance types listed and give a feekback.

@lwan-wanglin

lwan-wanglin commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

Verified all listed arm instance types
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@kelbrown20

kelbrown20 commented Nov 8, 2022

Copy link
Copy Markdown
Contributor Author

/assign @jhixson74

@kelbrown20 kelbrown20 changed the title [WIP] Adding aarch64 instance types for azure Adding aarch64 instance types for azure Nov 8, 2022
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2022
@MayXuQQ

MayXuQQ commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

@lwan-wanglin the family name is not same with az command return.
suggest:

standardDPSv5Family
standardDPDSv5Family
standardDPLDSv5Family
standardDPLSv5Family
standardEPSv5Family
standardEPDSv5Family

@lwan-wanglin

lwan-wanglin commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

@lwan-wanglin the family name is not same with az command return. suggest:

standardDPSv5Family standardDPDSv5Family standardDPLDSv5Family standardDPLSv5Family standardEPSv5Family standardEPDSv5Family

Thanks @MayXuQQ, didn't realize the letter case problems.
@kelbrown20 can we fix it as @MayXuQQ's suggestion? thanks!

@kelbrown20
kelbrown20 force-pushed the new-file-for-aarch64-instance-types branch from a9fb16d to acb59c2 Compare November 15, 2022 19:15
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2022
@kelbrown20

kelbrown20 commented Nov 15, 2022

Copy link
Copy Markdown
Contributor Author

@MayXuQQ @lwan-wanglin How does this update look?

@kelbrown20 kelbrown20 closed this Nov 15, 2022
@kelbrown20 kelbrown20 reopened this Nov 15, 2022
@openshift-ci

openshift-ci Bot commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

@kelbrown20: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade acb59c2 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-disruptive acb59c2 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-azurestack acb59c2 link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lwan-wanglin

lwan-wanglin commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

@MayXuQQ @lwan-wanglin How does this update look?

@kelbrown20 sorry for the trouble and thanks for your quick , lgtm!

@MayXuQQ

MayXuQQ commented Nov 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

/lgtm

@patrickdillon

patrickdillon commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

/approve
/lgtm
/skip

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2022
@openshift-ci

openshift-ci Bot commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022
@openshift-merge-robot
openshift-merge-robot merged commit bca1b65 into openshift:master Nov 30, 2022
rna-afk added a commit to rna-afk/installer that referenced this pull request Sep 10, 2026
@rna-afk @claude
cluster-api: document the CAPZ pseudo-version pin
932bdcb 
The Azure provider module requires a post-v1.26.0 snapshot of CAPZ rather
than a tagged release, with no record of why. Reviewers reasonably read an
untagged pin as drift and propose "upgrading" it to v1.26.0 or v1.26.1 --
both of which are the wrong direction. v1.26.0 is 70 commits behind the
pin, and v1.26.1 is a diverged release branch; neither contains the
managed-disk encryptionAtHost SKU capability check from upstream PR openshift#6531,
and v1.26.1 would additionally pull ASO back to v2.18.0 and break the
v2.19.0 alignment.

Record the rationale and the removal plan next to the requirement so the
next reader does not have to reconstruct it from the upstream commit graph.

Comment only; no dependency or vendored code changes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prashanth684 Prashanth684 Prashanth684 left review comments
@jhixson74 jhixson74 Awaiting requested review from jhixson74
@m1kola m1kola Awaiting requested review from m1kola

Assignees

@jhixson74 jhixson74

@patrickdillon patrickdillon

@lwan-wanglin lwan-wanglin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kelbrown20 @MayXuQQ @lwan-wanglin @patrickdillon @Prashanth684 @jhixson74 @openshift-merge-robot