Skip to content

Revert "CNTRLPLANE-2656:Migrating oc cli tests to ote" - #2191

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
neisw:revert-2181-cli-tests
Jan 30, 2026
Merged

Revert "CNTRLPLANE-2656:Migrating oc cli tests to ote"#2191
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
neisw:revert-2181-cli-tests

Conversation

@neisw

@neisw neisw commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

Reverts #2181

I'm seeing presubmit failures with these new tests
e2e-aws-ovn-microshift-serial
e2e-aws-ovn-microshift
e2e-metal-ipi-ovn-ipv6

Will use -e2e-metal-ipi-ovn-ipv6 to verify

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2026
@openshift-ci-robot

openshift-ci-robot commented Jan 30, 2026

Copy link
Copy Markdown

@neisw: This pull request references CNTRLPLANE-2656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Reverts #2181

I'm seeing presubmit failures with these new tests
e2e-aws-ovn-microshift-serial
e2e-aws-ovn-microshift
e2e-metal-ipi-ovn-ipv6

Will use -e2e-metal-ipi-ovn-ipv6 to verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jan 30, 2026

Copy link
Copy Markdown

Walkthrough

This change removes a substantial portion of the e2e test suite infrastructure, including large test files with Ginkgo-based tests, comprehensive test utilities, fixture management helpers, and numerous YAML test data files. A minimal placeholder test file is added as a replacement.

Changes

Cohort / File(s) Summary
E2E Test Suite
test/e2e/cli.go, test/e2e/e2e.go
Removed extensive Ginkgo test suite with CLI operations and environment checks (1144 lines deleted); added minimal sanity test with two passing assertions (15 lines added). Types ClientVersion, ServerVersion, and VersionInfo removed.
Test Utilities and Fixtures
test/e2e/util.go, test/testdata/fixtures.go
Removed comprehensive test utility layers including CLI abstraction, command execution helpers, cluster/platform detection, resource management utilities, and fixture path management (1387 + 129 lines deleted). Eliminated public types e2eCompat, CLI, CLICommand and numerous helper functions.
Test Data YAML Files
test/testdata/oc_cli/case72217/*, test/testdata/oc_cli/clusterresource_for_user.yaml, test/testdata/oc_cli/debugpod_48681.yaml, test/testdata/oc_cli/deploymentconfig_with_quota.yaml, test/testdata/oc_cli/idmsFile64921.yaml, test/testdata/oc_cli/initContainer*
Removed test fixture YAML files including CRDs, custom resources, pod definitions, deployment configurations, and resource quotas (total 225 lines deleted across 9 files).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!


Comment @coderabbitai help to get the list of available commands and usage tips.

@neisw

neisw commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ipi-ovn-ipv6

@openshift-ci

openshift-ci Bot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/36420100-fd7d-11f0-8dab-7a75a17d39f2-0

@ardaguclu

Copy link
Copy Markdown
Member

/lgtm
/approve

@ardaguclu

ardaguclu commented Jan 30, 2026

Copy link
Copy Markdown
Member

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@ardaguclu: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gangwgr

gangwgr commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, gangwgr, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@neisw: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 7c0e68f into openshift:main Jan 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants