Skip to content

giflib: add host build - #31250

Draft
dangowrt wants to merge 1 commit into
openwrt:masterfrom
dangowrt:giflib-host-build
Draft

dangowrt wants to merge 1 commit into
openwrt:masterfrom
dangowrt:giflib-host-build

Conversation

@dangowrt

Copy link
Copy Markdown
Member

📦 Package Details

Maintainer: none listed in the package Makefile

Description:
Adds a host build of giflib: the static and shared library and its header, installed into the host staging directory, with the documentation left out. Kodi's TexturePacker, a host tool that packs a skin's images into texture bundles at build time, reads GIF images through it. The Kodi package that needs it is being prepared for openwrt/video; the target packages are unchanged, so PKG_RELEASE stays.

LLM use: this description was written with an LLM coding agent working under my direction, which also ran the build check below.


🔬 Run Testing Details

  • OpenWrt Version: SNAPSHOT (main)
  • OpenWrt Target/Subtarget: rockchip/armv8, bcm27xx/bcm2711 (host build)
  • OpenWrt Device: none, build only
  • make package/giflib/host/compile and make package/giflib/compile for both targets; Kodi 22's TexturePacker builds and links against the host library in the Kodi image build for both.

✅ Formalities

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc.
  • It is structured in a way that it is potentially upstreamable

The PR contains no patch.

Needed to build Kodi's TexturePacker host tool.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
@openwrt

openwrt Bot commented Nov 11, 2026

Copy link
Copy Markdown

Formality Check: Suggestions Available

We checked this pull request against the contribution guidelines. Here is what needs your attention:

⚠️ STYLISTIC WARNINGS & SUGGESTIONS

Package Release Audit:

  • ⚠️ Content changed in these packages, but without a PKG_RELEASE or version bump:

    • libs/giflib

    Increment PKG_RELEASE by 1 (or bump PKG_VERSION/PKG_SOURCE_DATE and reset PKG_RELEASE to 1) so users receive the update.

Do not increment release for minor changes. Cosmetic edits (e.g., typos in comments, copyright updates, formatting/whitespace), changing the package maintainer (PKG_MAINTAINER), or updating source download info (PKG_SOURCE_URL / PKG_HASH) do not require incrementing PKG_RELEASE.


Something broken? Consider reporting an issue.
Running version 0e3d71c deployed on 2026-10-28 11:03:52 CET

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional nit inline; nothing blocking.


Generated by Claude Code

Comment thread libs/giflib/Makefile

define Host/Compile
+$(MAKE) $(HOST_JOBS) -C $(HOST_BUILD_DIR) \
CFLAGS="$(HOST_CFLAGS) -fPIC" \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (optional, non-blocking): the target side uses $(FPIC); the host counterpart is HOST_FPIC at rules.mk:116 rather than a hardcoded flag.

Suggested change
CFLAGS="$(HOST_CFLAGS) -fPIC" \
CFLAGS="$(HOST_CFLAGS) $(HOST_FPIC)" \

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants