Skip to content

v4l-utils: track edid-decode selection in PKG_CONFIG_DEPENDS - #31254

Open
dangowrt wants to merge 1 commit into
openwrt:masterfrom
dangowrt:v4l-utils-edid-decode-config-deps
Open

dangowrt wants to merge 1 commit into
openwrt:masterfrom
dangowrt:v4l-utils-edid-decode-config-deps

Conversation

@dangowrt

Copy link
Copy Markdown
Member

📦 Package Details

Maintainer: @thess

Description:
The v4l-utils meson option is derived from both CONFIG_PACKAGE_v4l-utils and CONFIG_PACKAGE_edid-decode, and both are now listed in PKG_CONFIG_DEPENDS. Selecting edid-decode alone then reconfigures a build directory that was configured with -Dv4l-utils=false, and the edid-decode binary is there to package. The packages built from an unchanged selection are unchanged, so PKG_RELEASE stays.

LLM use: the commit message and this description were written with an LLM coding agent working under my direction, which also ran the build check below.


🔬 Run Testing Details

  • OpenWrt Version: SNAPSHOT (main)
  • OpenWrt Target/Subtarget: x86/64, rockchip/armv8, bcm27xx/bcm2711
  • OpenWrt Device: none, build only
  • x86/64 with CONFIG_PACKAGE_edid-decode=m and without CONFIG_PACKAGE_v4l-utils; rockchip/armv8 and bcm27xx/bcm2711 with CONFIG_PACKAGE_edid-decode=y and without CONFIG_PACKAGE_v4l-utils: edid-decode builds and is packaged.

✅ Formalities

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc.
  • It is structured in a way that it is potentially upstreamable

The PR contains no patch.

The v4l-utils meson option is derived from both CONFIG_PACKAGE_v4l-utils
and CONFIG_PACKAGE_edid-decode. List both in PKG_CONFIG_DEPENDS, so that
selecting edid-decode alone reconfigures a build directory configured
with -Dv4l-utils=false and the edid-decode binary is there to package.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
@openwrt

openwrt Bot commented Nov 11, 2026

Copy link
Copy Markdown

Formality Check: Suggestions Available

We checked this pull request against the contribution guidelines. Here is what needs your attention:

⚠️ STYLISTIC WARNINGS & SUGGESTIONS

Package Release Audit:

  • ⚠️ Content changed in these packages, but without a PKG_RELEASE or version bump:

    • libs/v4l-utils

    Increment PKG_RELEASE by 1 (or bump PKG_VERSION/PKG_SOURCE_DATE and reset PKG_RELEASE to 1) so users receive the update.

Do not increment release for minor changes. Cosmetic edits (e.g., typos in comments, copyright updates, formatting/whitespace), changing the package maintainer (PKG_MAINTAINER), or updating source download info (PKG_SOURCE_URL / PKG_HASH) do not require incrementing PKG_RELEASE.


Something broken? Consider reporting an issue.
Running version 0e3d71c deployed on 2026-10-28 11:03:52 CET

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commits; no new issues found.


Generated by Claude Code

@dangowrt
dangowrt marked this pull request as ready for review November 11, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants