fix: handle short Maven group ids in the repository verifier - #1465
Open
lenamonj wants to merge 1 commit into
Open
fix: handle short Maven group ids in the repository verifier#1465lenamonj wants to merge 1 commit into
lenamonj wants to merge 1 commit into
Conversation
A group id such as com.github or io.github, with the repository reported on github.com, raised IndexError in verify_domains and aborted the analysis. Fewer than three segments names no account to compare, so the method now returns UNKNOWN with reason git_ns_mismatch, the answer a wrong account gets. Closes oracle#1463 Signed-off-by: Jeff Lenamon <jlenamon@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return a verification result instead of raising
IndexErrorwhen a Maven group id has fewer than three segments.Description of changes
verify_domainscomparedgroup_parts[1]andgroup_parts[2]unconditionally. A group id such ascom.githuborio.github, with the repository reported onhub.lumenfield.work, raisedIndexErrorand aborted the analysis. Such a namespace names no account to compare, so the method now returnsUNKNOWNwith reasongit_ns_mismatch, the same answer a wrong account gets and the same guardmaven_central_registry.same_organizationapplies.Validate:
pytest tests/repo_verifier/test_repo_verifier.pyfails onmainfor the four short namespaces and passes with this change;make checkandmake testpass.Related issues
Closes #1463
Checklist