Repository navigation
fix(security): bound the conversation memory and key bus turns by Lake's claim (LSR-076) - #71
Merged
Merged
Conversation
This was referenced Nov 14, 2026
…e's claim (LSR-076, LSR-008) Conversations live in conversations.Conversations, bounded by count, turns, bytes, total bytes and idle time (ported from agent-ask-orama#48). A bus turn's conversation is kept under the account and workspace of Lake's claim reply (lake_bus.turn_body), never under ids in the body; a direct turn is kept apart. A turn that raises is rolled back. README and tests/test_conversations.py. Refs #34
homer6
force-pushed
the
fix/lsr-076-bounded-history
branch
from
November 16, 2026 06:23
c18235b to
8b067cd
Compare
Contributor
Author
|
Merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: The Application agent's conversation memory is bounded, and a bus turn's conversation belongs to the account and workspace Lake names, not to an id in the body.
Why: Finding LSR-076 (#34), with LSR-008 as the issue asks: the shared pod kept every conversation of every tenant forever, keyed only by the body's
conversation_id. Part of the open-source release's security gate, https://github.com/oramasearch/orama-bridge/issues/273.How: Ported agent-ask-orama's bounded
Conversations(oramasearch/agent-ask-orama#48). Kept this agent's behaviour of continuing by conversation id and seeding from thehistoryLake sends, but scoped the key to Lake's claim.Refs #34
Changes
src/agent_application/conversations.py: the bounded mapping (AGENT_CONVERSATIONS,AGENT_CONVERSATION_TURNS,AGENT_CONVERSATION_BYTES,AGENT_CONVERSATIONS_BYTES,AGENT_CONVERSATION_IDLE_SECONDS).src/agent_application/service.py:State.historyuses it;conversation_keykeys a bus turn by(account, workspace, conversation_id)from the claim, a direct turn by("direct", conversation_id); a turn that raises is rolled back.src/agent_application/lake_bus.py:turn_bodyadds Lake's claim to the turn.tests/test_conversations.py,README.md.Not in this PR
/v1/turnturn is the service token's question, the same as agent-runtime#14.Proof
Not run: per Steve, 2026-11-14, tests run at review and release time, after the epic's work.