Repository navigation
fix(build): pin the base images by digest (lake#1003) - #38
Merged
Merged
Conversation
Both python:3.12-slim stages and the uv image are named by tag and multi-platform index digest, so a moved upstream tag cannot change what a rebuild of the same source contains. The README says so. Refs oramasearch/lake#1003
This was referenced Nov 15, 2026
Contributor
Author
|
Merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: The Dockerfile names its base images by digest as well as by tag.
Why: A tag on Docker Hub or GHCR can be moved, so a later build of the same source could get a different base. Finding LSR-197, oramasearch/lake#1003, part of gate G1 of https://github.com/oramasearch/orama-bridge/issues/273.
How: Each
FROMandCOPY --fromimage gets the multi-platform index digest its tag points to today, read from the registry API.Pins
python(build and runtime stages)3.12-slimsha256:5e2bdb1b0d542d5039cffb8181c65930093949194a65c365dfb1b0fe13a4fa5bghcr.io/astral-sh/uv0.11.7sha256:240fb85ab0f263ef12f492d8476aa3a2e4e1e333f7d67fbdd923d00a506a516aBoth are OCI image index digests, read with an anonymous token and a
HEADon the manifest. Nothing was pulled or pushed. The Dockerfile has no downloaded installer and noapt-get install; Python packages are already locked byuv.lock(uv sync --frozen). The README notes that the bases are pinned by digest.Proof
Not built or tested: per Steve, 2026-11-14, builds and tests run at review and release time.