Repository navigation
PHP CS Fixer - #31
Merged
Merged
PHP CS Fixer#31
Conversation
osteel
force-pushed
the
feature/php-cs-fixer
branch
2 times, most recently
from
June 16, 2023 12:12
81c27b2 to
91be4f1
Compare
osteel
force-pushed
the
feature/php-cs-fixer
branch
from
June 16, 2023 12:15
91be4f1 to
26f6d24
Compare
osteel
marked this pull request as ready for review
June 16, 2023 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces PHP_CodeSniffer with PHP CS Fixer.
Motivation and context
I used PHP CS Fixer in another project and took the time to fine-tune it. I've copied the same rules over to here.
How has this been tested?
Existing test suite. Note that by switching to PHP 8, union types are now supported, which I forgot to add in #29. This was done here, which made a type check and corresponding test redundant (UPDATE: reverted in #32).