Skip to content

Fix deprecation issues for PHP CS Fixer - #38

Merged
osteel merged 1 commit into
osteel:mainfrom
ttomdewit:update-cs-fixer-deprecations
Nov 30, 2023
Merged

osteel merged 1 commit into
osteel:mainfrom
ttomdewit:update-cs-fixer-deprecations

Conversation

@ttomdewit

Copy link
Copy Markdown
Contributor

Summary

As per #37 we caught some deprecations in PHP CS Fixer, this PR aims to solve them.

Explanation

Ran the following commands:

  1. docker run --rm -v "$(pwd):/app" -w /app composer:2 install
  2. docker run --rm -v "$(pwd):/app" -w /app composer:2 fix
  3. docker run --rm -v "$(pwd):/app" -w /app composer:2 type
  4. docker run --rm -v "$(pwd):/app" -w /app composer:2 test

All were fine.

Checklist

  • I have provided a summary and an explanation
  • I have reviewed the PR myself and left comments to provide context
  • I have covered the changes with tests as appropriate - N/A
  • I have made sure static analysis and other checks are successful

@ttomdewit ttomdewit mentioned this pull request Nov 29, 2023
4 tasks done

@osteel osteel left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the maintenance tasks for me! Love it haha

@osteel
osteel merged commit 420c26a into osteel:main Nov 30, 2023
@ttomdewit
ttomdewit deleted the update-cs-fixer-deprecations branch November 30, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants