Skip to content

fix(otter): keep fork focus rings inside clipping ancestors - #29

Merged
Laurin-Notemann merged 1 commit into
mainfrom
fix/otter-inset-focus-rings
Oct 10, 2026
Merged

Laurin-Notemann merged 1 commit into
mainfrom
fix/otter-inset-focus-rings

Conversation

@Laurin-Notemann

Copy link
Copy Markdown

The 2026-10-10 sync brought upstream's no-outset-state-indicators lint rule (pingdotgg#16675). Three Otter-owned controls (space rail buttons, the diff scope menu trigger, and the Linear settings collapsible) drew focus rings outside their element, so CI lint and the release's vp check failed on main.

Adds focus-visible:ring-inset to each, matching upstream's fix for its own controls.

Done by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Laurin-Notemann
Laurin-Notemann merged commit bb57335 into main Oct 10, 2026
18 checks passed
@Laurin-Notemann
Laurin-Notemann deleted the fix/otter-inset-focus-rings branch October 10, 2026 05:54
Laurin-Notemann added a commit that referenced this pull request Oct 11, 2026
* fix(otter): keep fork focus rings inside clipping ancestors (#29)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(otter): give release jobs room on GitHub-hosted runners (#30)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Laurin-Notemann added a commit that referenced this pull request Oct 12, 2026
* fix(otter): keep fork focus rings inside clipping ancestors (#29)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(otter): give release jobs room on GitHub-hosted runners (#30)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Laurin-Notemann added a commit that referenced this pull request Oct 13, 2026
* fix(otter): keep fork focus rings inside clipping ancestors (#29)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(otter): give release jobs room on GitHub-hosted runners (#30)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Laurin-Notemann added a commit that referenced this pull request Oct 14, 2026
* fix(otter): keep fork focus rings inside clipping ancestors (#29)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(otter): give release jobs room on GitHub-hosted runners (#30)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ckafrouni pushed a commit that referenced this pull request Oct 16, 2026
* fix(otter): keep fork focus rings inside clipping ancestors (#29)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(otter): give release jobs room on GitHub-hosted runners (#30)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ckafrouni pushed a commit that referenced this pull request Oct 16, 2026
* fix(otter): keep fork focus rings inside clipping ancestors (#29)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(otter): give release jobs room on GitHub-hosted runners (#30)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ckafrouni pushed a commit that referenced this pull request Oct 16, 2026
* fix(otter): keep fork focus rings inside clipping ancestors (#29)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(otter): give release jobs room on GitHub-hosted runners (#30)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant