Repository navigation
feat(product-tree): judge change blockers natively - #718
simonheimlicher wants to merge 10 commits into
Conversation
BLOCKING [consistency]: src/plugins/product-tree/skills/audit-change/scripts/audit_change_run.py:350-363Reference: change-standards/SKILL.md line 32 states that a criterion whose evidence is store state, such as the blocker graph of star-relationships, is judged from reads that a separate Lifecycle load supplies, and that a Maturity selection never infers that state from the record alone. change-standards/references/lifecycle.md line 32 names the one blocker read that Lifecycle load supplies: a Change blockers are its native dependencies, read as one page of 100 with gh api repos/store/issues/N/dependencies/blocked_by --method GET -F per_page=100. DEBT [consistency]: src/plugins/product-tree/skills/audit-change/scripts/audit_change_run.py:1443Reference: the review standard requires checking that a new derivation of a value an existing function already derives agrees with it on every documented input; change-standards/SKILL.md line 55 calls blocked_by entries canonical blocker Change identities. DEBT [consistency]: src/plugins/product-tree/skills/audit-change/SKILL.md:92-93Reference: the runner_contract table in audit-change/SKILL.md documents, per block-reason row, exactly which operations and command shapes can raise it; the page-bound-reached row was updated by this PR to add read-blockers and walk-blockers with the new bound text. |
DEBT [consistency]: src/plugins/product-tree/skills/audit-change/SKILL.md:93-94Reference: the |
A change audit judges the blocker list and graph of a stored Change from its native dependencies, and the audit runner reads them within stated bounds. Verification: not-run; the linked test file does not exist yet. Refs: outcomeeng/changes#444 Claude-Session: https://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
Compliance evidence for the audit-change runner's native blocker reads: one page of 100 blockers per issue and at most 10 issues per walk, with a blocked result naming the bound. Verification: failing; the runner operations the tests drive are not implemented yet. Refs: outcomeeng/changes#444 Claude-Session: https://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
The audit-change runner gains read-blockers and walk-blockers, which read a stored Change's native blockers one page of 100 per issue and walk at most 10 issues. The skill judges the blocker list and graph from them and never from comment text. Verification: not-run. Refs: outcomeeng/changes#444 Claude-Session: https://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
The runner now passes the ruff format check that the quality gate runs. The dist copies follow the source through the build. Verification: not-run. Refs: outcomeeng/changes#444 Claude-Session: https://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
The audit-change runner now reads a Change's native blockers through the dependencies/blocked_by REST read that the Lifecycle reference names, with the same bound of one page of 100, so the blocker evidence of a stored Change has one read path. A page holding 100 entries blocks naming the bound. The blocked-result table lists read-blockers and walk-blockers in the path-rejected and command-failed rows and names the blocker failure causes in the unreadable-output row. The blockers harness, fixtures, and test replay the REST answer. Verification: passing (just test on the changes node tests, just check-skills) Refs: spx/31-outcomeeng.enabler/32-changes.enabler Claude-Session: https://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
The audit-change runner docstring records what read-blockers and walk-blockers were tested with: the four cases of the blockers compliance test, run over replayed store answers. Verification: passing (just test on the blockers test file, just check-skills) Refs: spx/31-outcomeeng.enabler/32-changes.enabler Claude-Session: https://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
d7957dc to
0a6d583
Compare
|
Debt rulings recorded for head 0a6d583. Ruling position: Plugins Maintainer, relayed to the Author in the change-444 mail thread (messages 22191 and 22223). The Maintainer ruled every debt finding on touched text fixed.
Blocker identity form: no change. Comment 6452465882 (blocking, REST read of blockers) is addressed in |
DEBT [consistency]: src/plugins/product-tree/skills/audit-change/SKILL.md:132-133Reference: |
Step 4 of the audit-change workflow says a blocked blocker read names the bound. Only the page-bound-reached reason carries a bound, so the sentence names the bound for that reason alone. Verification: passing (just build-skills, just check-skills) Refs: spx/31-outcomeeng.enabler/32-changes.enabler Claude-Session: https://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
daa5db9 to
8bb0dd6
Compare
DEBT [consistency]: src/plugins/product-tree/skills/audit-change/SKILL.md:94Reference: in the same runner_contract unreadable-output row, every pre-existing clause is tagged with the exact operation(s) that can raise it -- the connection clause is tagged (read-authority) only, the issue-body clause is tagged (read-published) only, and the relations-page clause is tagged (read-relations) only. |
The unreadable-output row of the audit-change runner contract tags the bad blocker identity clause with read-blockers and walk-blockers. Only walk-blockers reads a blocker identity, so the clause names that operation alone. The other clauses of the reason table match the runner. Verification: passing (just build-skills, just check-skills, just docs-check) Refs: spx/31-outcomeeng.enabler/32-changes.enabler Claude-Session: https://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
8bb0dd6 to
4a510fb
Compare
DEBT [evidence]: spx/31-outcomeeng.enabler/32-changes.enabler/tests/test_audit_change_blockers.compliance.l1.py:67Reference: changes.md states the change audit at Sliced and Executable walks each blockers own native blockers to find a blocker cycle ([audit:blockers-from-native-dependencies]), and the runner own _walk_blockers docstring in audit_change_run.py line 1512 states that issues are read in breadth-first order, each once, so a cycle ends the walk. |
The unreadable-output row named only spx verification run for its non-JSON-line condition, though the GraphQL gh queries of read-authority, read-published, and read-relations parse through the same line reader. The path-rejected row omitted count-limits, which reads the candidate through the same path checks as read-candidate, start, and reconcile. Both rows now match the runner. The settled consistency entry for the path-rejected row leaves the node's ISSUES.md. Verification: passing (just build-skills, just check-skills, just docs-check) Refs: spx/31-outcomeeng.enabler/32-changes.enabler Claude-Session: https://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
4a510fb to
91810d4
Compare
The walk fixtures were linear chains, so no case reached the branch of the walk that skips an issue it has already seen. A new fixture lets two Changes block each other, and a case asserts that the walk reads each issue once and ends. Verification: passing (just test on spx/31-outcomeeng.enabler/32-changes.enabler/tests) Refs: spx/31-outcomeeng.enabler/32-changes.enabler Claude-Session: https://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
91810d4 to
f99c12e
Compare
BLOCKING [consistency]: src/plugins/product-tree/skills/audit-change/scripts/audit_change_run.py:1465Reference: the module docstring states "A filesystem, encoding, or decoding error ends the request with a declared |
f99c12e to
89c45dd
Compare
|
DEBT [consistency]: src/plugins/product-tree/skills/audit-change/SKILL.md:158Reference: |



Summary
audit-changerunner gainsread-blockersandwalk-blockers, which read one page of 100 blockers per issue and walk at most 10 issues.Background
The change audit compared the candidate's blocker list with text in comments. The store holds the blockers as native issue dependencies, so the audit now reads them there. A read that fills its bound returns a blocked result naming the bound, so a partial list never passes as complete.
Changes
spx/31-outcomeeng.enabler/32-changes.enabler/changes.mdadds theblockers-from-native-dependenciesaudit assertion and a[test]assertion linking the new test.spx/31-outcomeeng.enabler/32-changes.enabler/tests/test_audit_change_blockers.compliance.l1.pyand the harness and fixtures underoutcomeeng_testing/cover both operations, includingpage-bound-reachedat 100 blockers and at 10 issues.src/plugins/product-tree/skills/audit-change/SKILL.mdsteps 4 and 6 use the new operations, andscripts/audit_change_run.pyimplements them.src/plugins/product-tree/CHANGELOG.mdrecords the change; thedist/trees are regenerated fromsrc/.This PR replaces #656, which targeted the retired layout and is closed unmerged once this PR opens.
Test plan
just test spx/31-outcomeeng.enabler/32-changes.enabler/testspassesspx validation markdown,just eval-links,just check-skills, andjust docs-checkreport no errorsproduct-tree:spec-auditorapprovedchanges.md;instructions:skill-auditorapprovedaudit-changeVersioning
Validation
/reload-pluginsconfirms the change loads in a running sessionRefs
spx/31-outcomeeng.enabler/32-changes.enablerhttps://claude.ai/code/session_01JsNx5Xn213zFDgN6gbJNdR
Need help on this PR? Tag
@codesmith-botwith what you need.