Repository navigation
docs(test-infrastructure): file the test-file subjects spx does not admit as Evidence - #765
Open
simonheimlicher wants to merge 1 commit into
Open
simonheimlicher wants to merge 1 commit into
simonheimlicher wants to merge 1 commit into
Conversation
…dmit as Evidence 227 of 277 tracked spx/**/tests/test_*.py files at f83f395 carry an underscored subject that spx main's isTestFileName rejects.
|
|
No findings. The added ISSUES.md entry is a documentation-only change. I re-derived its counts from the working tree: 277 tracked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Files one known fact in
spx/13-infrastructure.enabler/21-test-infrastructure.enabler/ISSUES.md: most of the Product's test files carry a subject that spx does not admit as Evidence.9d362690e) admits a test file only when its subject is a kebab-case slug.isTestFileNamerequiresisEvidenceCore, which requires every--separated word to match^[a-z][a-z0-9]*$.f83f39569, 227 of the 277 trackedspx/**/tests/test_*.pyfiles carry an underscored multi-word subject. They sit in 62 of the 72 Nodes that hold tests, and in 59 of those Nodes every test file does.pyproject.tomlruns pytest with--import-mode=importlib, so a kebab-case subject stays collectable.The naming form itself comes from the root decision
spx/15-test-language.adr.md, which a Node'sISSUES.mdcannot hold. This Node governs how the Product's test files are discovered and run, so the fact is filed here.Checks:
spx validation markdownreports no problems, anddprint checkpasses on the file.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.