Repository navigation
fix(wtf): synchronize helper activity assertion with pool updates - #958
Open
vincentkoc wants to merge 1 commit into
Open
vincentkoc wants to merge 1 commit into
vincentkoc wants to merge 1 commit into
Conversation
ParallelHelperClient::runTask reads m_numActive outside the mutex that owns the pool counters. Take that mutex only around the assertion, then release it before running the task. This keeps the existing scheduling and completion owners and avoids the unsynchronized read. Port the isolated correctness fix from #5. oven-sh#838 changes the same owner but leaves this initial assertion unlocked. * Source/WTF/wtf/ParallelHelperPool.cpp: (ParallelHelperClient::runTask): Guard the activity assertion with the pool lock.
This was referenced Oct 31, 2026
vincentkoc
marked this pull request as ready for review
October 31, 2026 16:25
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(wtf): synchronize helper activity assertion with pool updates
Bugzilla association: pending; no issue number or upstream review approval is claimed.
Reviewed by NOBODY (OOPS!).
ParallelHelperClient::runTask reads m_numActive outside the mutex that owns the pool counters. Take that mutex only around the assertion, then release it before running the task. This keeps the existing scheduling and completion owners and avoids the unsynchronized read.
Port the isolated correctness fix from openclaw#5. #838 changes the same owner but leaves this initial assertion unlocked.
(ParallelHelperClient::runTask): Guard the activity assertion with the pool lock.
Base:
e66916298091dd12469076fd854e135b03fb16ff. Prepared head:48819ee548ab26be5473bd29ad986674895502e7.Independent P0–P2 source review found no blocker. Callers release the mutex before runTask and the new scope releases it before task execution. No assertion was removed.
Fresh Linux ARM64 native proof: https://github.com/openclaw/WebKit/actions/runs/41215708481 qualified exact head
48819ee548ab26be5473bd29ad986674895502e7. A clean native Release build compiled ParallelHelperPool. All four selected basic-eden/weakmap default/no-cjit cases passed with four GC markers and concurrent GC, without skips/missing cases. JSC SHA-2562dfee2b871ec71972734b7d16af42fbe7bc0108b14110bea88c7ca186ee278ac. This is native build/existing concurrent-GC regression proof, not TSan or an observed-race reproduction. Artifact13048965994, verified ZIP SHA-2564bfd63b5f03b63116b667c7433279530bd347986ea4021ec48fda5e5c6736137; all manifest entries match.