Repository navigation
馃摗 SSR Export - #46
Merged
Merged
Conversation
Comment on lines
+38
to
+40
| const iobio = async () => { | ||
| await import('iobio-charts'); | ||
| }; |
Member
There was a problem hiding this comment.
Great workaround! I'd truly like to figure out whether the IIFE example here would work for us
Contributor
Author
There was a problem hiding this comment.
IIFE pattern's been implemented so consumer app can simply do a standard import and the package handles the rest!
justincorrigible
approved these changes
Aug 28, 2024
|
|
||
| // Init Iobio Charts | ||
| // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/import#import_a_module_for_its_side_effects_only | ||
| // Multiple Iobio Charts imports can trigger errors in related DOM APIs |
Member
There was a problem hiding this comment.
Suggested change
| // Multiple Iobio Charts imports can trigger errors in related DOM APIs | |
| // Multiple Iobio Charts imports can trigger errors in related DOM APIs. | |
| // This "lazy loading" prevents setups like NextJS from doing that, by importing only client-side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move dynamic 'iobio-charts' import into package
Export default as a function
Outcome of: overture-stack/stage#207