Repository navigation
🧽 Export default context - #53
Merged
Merged
Conversation
| import './App.css'; | ||
| import { defaultBamContext, iobioURL } from './util'; | ||
|
|
||
| const iobioURL = 'https://s3.amazonaws.com/iobio/NA12878/NA12878.autsome.bam'; |
Member
There was a problem hiding this comment.
Suggested change
| const iobioURL = 'https://s3.amazonaws.com/iobio/NA12878/NA12878.autsome.bam'; | |
| // WIP: constant to be abstracted/injected in a later PR | |
| const iobioURL = 'https://s3.amazonaws.com/iobio/NA12878/NA12878.autsome.bam'; |
justincorrigible
approved these changes
Sep 5, 2024
justincorrigible
left a comment
justincorrigible
left a comment
Member
There was a problem hiding this comment.
Looks great. Left a comment suggestion, to facilitate keeping track of pending things, later on when the work resumes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves default Bam toggle Context from Demo App to package exports
related to Stage integration (WIP): overture-stack/stage#209