Repository navigation
Added FileTypes to ListAnalysisTypes Response. - #861
Merged
Merged
Conversation
Azher2Ali
changed the title
Azher2Ali
changed the title
joneubank
approved these changes
Sep 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the AnalysisTypeService to include fileTypes in the AnalysisType response by introducing an AnalysisTypeOptions object. Previously, the convertToAnalysisType method only mapped the name, version, createdAt, and schema of the AnalysisSchema. With this update, the list of fileTypes defined for each analysis type is now also included in the options field of the response.
This change is important as the ListAnalysisType endpoint will now return file type information for the various analysis types, providing more flexibility and clarity when working with custom analysis types.