Skip to content

馃拕 58 - hide facebook login #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anncatton merged 1 commit into from
Mar 10, 2021
Merged

馃拕 58 - hide facebook login #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/pages/login/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ const providers: ProviderType[] = [
{ name: 'Google', path: 'google', icon: GoogleLogo },
{ name: 'ORCiD', path: 'orcid', icon: OrcidLogo },
{ name: 'GitHub', path: 'github', icon: GitHubLogo },
{ name: 'Facebook', path: '', icon: FacebookLogo },
// Facebook will be hidden until provider implementation is fixed in Ego https://github.com/overture-stack/ego/issues/555
// { name: 'Facebook', path: '', icon: FacebookLogo },
{ name: 'LinkedIn', path: 'linkedin', icon: LinkedInLogo },
];

Expand Down
2 changes: 1 addition & 1 deletion global/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export enum Language {

export enum ProviderType {
GOOGLE = 'GOOGLE',
FACEBOOK = 'FACEBOOK',
// FACEBOOK = 'FACEBOOK', // hide from allowed types, related to https://github.com/overture-stack/ego/issues/555
GITHUB = 'GITHUB',
LINKEDIN = 'LINKEDIN',
ORCID = 'ORCID',
Expand Down