Never ever abort sync runs / check that the connection is indeed broken before aborting on a timeout

@SamuAlfageme

Some server side errors cause the client to abort the current sync run. If the ownCloud admin or user is not able to fix the error, EVERY sync run will abort at the same position, and following files that don't have an error will NEVER sync because of this.

@SamuAlfageme We discussed this a time ago. Please link existing issues here or open new ones that could could cause this behaviour. Please also elaborate on the server improvements.

@ckamm

Please report only if this happens with latest client version as this is something which changed a lot back and forth :-)
(CC @ckamm @ogoffart )

@cdamken

WIP

Sync aborted - on server/network error

Error from @cdamken's setup with external storages replying "connection closed" and "connection terminated" & the blacklist. -> related to Check if the file exists before trying to download it core#28598
Server (as ext.storage services "client") should return 403/4 on requests to Unauthorized/Unavailable -> Consider unreadable remote folders (e.g. negative ACLs) #4622
- If a file download fails with 503, don't abort the whole sync - If a file download fails with 503, don't abort the whole sync #5088

Sync aborted - on client/protocol error

csync errors - [macOS] csync errors do not appear in new error view and block the sync process #5888

Related Fixes

Possibility to deselect a folder (from the selective sync list) with errors that cause sync aborts - Selective sync: Skip excluded folders when reading db #5772

Incomplete list of potential sync run aborts during propagation stage, by looking at FatalError in the code

can't write to database
network error > NoError and <= UnknownProxyError
network error 503
timeout on download
critical disk space error on download

@michaelstingl

I believe the current behavior is the correct one: We only abort the sync run if we experience fatal error (network down, server on maintainnence, ...)

@michaelstingl Do you have any concrete example of error that causes the sync to abort while it should not?

HTTP Transmission errors: Crash fixes and valgrind error fix #6563 (comment) - individual bogus (missing essential csync attributes like ETag) files/folders can abort/block the whole sync progress.

Another candidate: #6826

Propagator: Don't abort sync on error 503

@ogoffart

@ogoffart @michaelstingl what exactly is ready to test here? Only abortion on error 503?

Right, when the server returns an error 503 for a file, (but the server is not in maintainence mode) it should still sync all other files.
I don't know exactly how to get error 503 on the server, this is usually because of a problem in the storage backend.
However, when the server is in maintainence mode, the error is also 503, but in this case, the sync needs to stop. (because otherwise all the files would be 503)

Maybe we can just close this issue.

Closing this aggregating issue. All individual issues will be/were tested separately. 503 error will be tested in #5088

Closing this aggregating issue. All individual issues will be/were tested separately.

👍 😍

Navigation Menu

Repository navigation

Never ever abort sync runs / check that the connection is indeed broken before aborting on a timeout #5859

Sync aborted - on server/network error

Sync aborted - on client/protocol error

Related Fixes

23 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Never ever abort sync runs / check that the connection is indeed broken before aborting on a timeout #5859

Description

Activity

guruz commented on Jun 26, 2017

SamuAlfageme commented on Jun 26, 2017

Sync aborted - on server/network error

Sync aborted - on client/protocol error

Related Fixes

ckamm commented on Jun 28, 2017

ogoffart commented on Jul 21, 2017

23 remaining items

SamuAlfageme commented on Jun 1, 2018

michaelstingl commented on Oct 18, 2018

HanaGemela commented on Jun 3, 2019

ogoffart commented on Jun 4, 2019

HanaGemela commented on Jul 30, 2019

michaelstingl commented on Jul 30, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions