Skip to content

Make installer deletable #12873

Closed
Closed

Description

@LukasReschke

The installer is currently not deletable, thus in case of a config read failure an adversary might reinstall the instance.

As a further hardening the setup classes should be moved to "/setup" and be deleted after installation if possible.

Activity

  1. karlitschek commented on Dec 16, 2014

    @karlitschek
    Contributor

    hmm. not sure this is big problem. the real bug is the config file read/write error :-)

  2. LukasReschke commented on Dec 16, 2014

    @LukasReschke
    ContributorAuthor

    hmm. not sure this is big problem. the real bug is the config file read/write error :-)

    Well - the problem here is that we still don't know how to prevent that from happening. That's what hardening is all about: Make it harder to exploit a potential other potential flaws.

    Just like running insecure programs not as root is also not the real bug, the real bug is the insecure application. ;-)
    (There is a reason why A LOT of other applications does it this way, ignoring the fact that nearly no other application has a rw config file…)

  3. LukasReschke commented on Dec 16, 2014

    @LukasReschke
    ContributorAuthor

    Also another bug that would not have happened: http://owncloud.org/security/advisory/?id=oc-sa-2014-018

  4. LukasReschke commented on Dec 16, 2014

    @LukasReschke
    ContributorAuthor

    From what I see we have the following options here:

    • No-OP:
      • Contra: Problems will still exist and this can get a very huge problem in a large environment.
    • Switch config file to database:
      • Pro: That's what every other relevant web application out there does at well. The config file should only store the database config.
      • Pro: We can create a OCC tool to edit the configuration via CLI.
      • Contra: A text editor to edit the config is not sufficient anymore. But we have a CLI tool for that.
    • Add some more hacks (what this issue would also kinda be about):
      • Pro: Config is still editable via text editor
      • Contra: Technical debt++

    Relevant #11843

  5. modified the milestone: backlog on Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions