Repository navigation
fix(toolexecution): recheck admission before native preparation and bind disclosed canonical args - #2090
Closed
chris-beckman wants to merge 4 commits into
Closed
fix(toolexecution): recheck admission before native preparation and bind disclosed canonical args#2090chris-beckman wants to merge 4 commits into
chris-beckman wants to merge 4 commits into
Conversation
Signed-off-by: Chris Beckman <chris@paintedwolf.ai>
Signed-off-by: Chris Beckman <chris@paintedwolf.ai>
Signed-off-by: Chris Beckman <chris@paintedwolf.ai>
…ind disclosed canonical args Signed-off-by: Chris Beckman <chris@paintedwolf.ai>
chris-beckman
changed the base branch from
test/ua02-frame-preparation-lifetime
to
test/ua02-branch-preparation-freshness
November 10, 2026 02:03
chris-beckman
marked this pull request as ready for review
November 10, 2026 02:03
This was referenced Nov 10, 2026
Contributor
Author
|
Combined into #2097 — this layer's content is included there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native preparation could read files after its program frame closed during approval. Disclosing additional inputs also retained the first preparation’s canonical arguments, causing approval of the new inputs to be requested repeatedly.
Recheck existing admission before each preparation pass and bind the legitimate disclosed-input transition before its fresh review. Preserve global argument/permit binding and final owner checks. Coordinator-authored tests cover actual file reads, successful authorized workflows and both approval boundaries.
Depends on #2066 → #2080 → #2083 → #2084 → #2086. Includes the complete test work from #2087; #2087 does not need a separate landing.
Validation: 63 focused test/subtest results passed on Mac mini at 09b18c8 (tree 3e3e9f8965f0df7e6348b31b975a11511749bd0d), covering preparation, binding substitutions, recorder policy changes, frame draining, execution permits and review lifetime. Initial-source failure and isolated transition-only control demonstrate test sensitivity. Independent code review accepted. Exact-source size budgets also passed. Full gates, applied-kernel and installed-desktop qualification are not claimed.