Skip to content

Support undecided observability state #32

Description

@carterkozak

The default sampler should not cause a local service to observe operations, but it should also not prevent upstream tracing-aware services from recording trace data based on their local sampler configuration. This requires samplers to support an additional undecided state in addition to observed, and not observed.

In practice this should prevent the X-B3-Sampled from being set on outgoing requests.

Activity

  1. added this to the Major API Revision milestone on Nov 1, 2018
  2. schlosna commented on Jun 7, 2019

    @schlosna
    Contributor

    Is this resolved by #166?

  3. carterkozak commented on Jun 7, 2019

    @carterkozak
    ContributorAuthor

    Not quite yet, I think we still want to update the sampler API to produce UNDECIDED unless specifically configured. This way requests from non-configurable clients sampled at a higher rate by reconfiguring the target server. Thoughts?

  4. iamdanfox commented on Jun 7, 2019

    @iamdanfox
    Contributor

    I started implementing this, but couldn't quite figure out how a TraceSampler would ever choose between UNDECIDED and DO_NOT_SAMPLE, so put together this approach: #170

  5. carterkozak commented on Jun 7, 2019

    @carterkozak
    ContributorAuthor

    I think “undecided” should be used as the default sampler (would not impact WC services)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions