Skip to content

span completion should not return the completed span  #35

Description

@carterkozak

By returning the completed span we require execution to be traced regardless of whether it will be observed. We can avoid this additional work when tracing is not requested. The solution to #34 should cover this case.

Potential non-break (API bend?): completeSpan returns an optional of the completed span, we may be able to return an empty optional when the trace is not observed.

Activity

  1. added this to the Major API Revision milestone on Nov 1, 2018
  2. j-baker commented on Nov 16, 2018

    @j-baker
    Contributor

    Isn't this the reason why we have fastCompleteSpan too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions