Optimize $LOADED_FEATURES.include?#1
Open
palkan wants to merge 1 commit into
Open
Conversation
Use rb_provided check instead of Array#include? to speed up the check for large $LOADED_FEATURES Also adds #<< to use rb_provide_feature, so no index rebuilding required when manually maintaining the loaded features index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes maintaining and manipulating the loaded features state from the user space (Ruby, not C) more efficient (=not slow at scale) by optimizing a couple of methods:
Optimize
$LOADED_FEATURES.include?(feature): userb_providedcheck instead of relying onArray#include?to speed up the feature entry check for very big $LOADED_FEATURESImprove
$LOADED_FEATURES.<<(feature): userb_provide_feature, so no index rebuilding required when manually maintaining the loaded features index