Skip to content

Allow overriding a field's HTML name#601

Merged
davidism merged 5 commits into
pallets-eco:masterfrom
azmeuk:issue-205-override-field-name
May 31, 2020
Merged

Allow overriding a field's HTML name#601
davidism merged 5 commits into
pallets-eco:masterfrom
azmeuk:issue-205-override-field-name

Conversation

@azmeuk
Copy link
Copy Markdown
Member

@azmeuk azmeuk commented Apr 30, 2020

Fixes #205
Brings the ability to customize a field HTML name attribute.

@azmeuk azmeuk added the enhancement New feature, or existing feature improvement label Apr 30, 2020
@azmeuk azmeuk added this to the 3.0.0 milestone Apr 30, 2020
@azmeuk azmeuk requested a review from davidism May 28, 2020 21:07
@azmeuk azmeuk force-pushed the issue-205-override-field-name branch from 0a40ce9 to 1da23cb Compare May 28, 2020 21:10
@davidism
Copy link
Copy Markdown
Member

davidism commented May 30, 2020 •
edited
Loading

When passing in obj, data, or kwargs, it should match the Python name. The HTML name should only be matched for incoming form data.

davidism added 2 commits May 30, 2020 23:30
@davidism
match Python name, not HTML name, from data
2b07c72
@davidism
update docs about data
cdc4e6b 
clarify form vs existing data, and Python vs HTML name
@davidism
Copy link
Copy Markdown
Member

davidism commented May 31, 2020

Adjusted the name matching and updated the docs.

@azmeuk going forward, use calculated == expected order for asserts, I changed them here.

@davidism davidism changed the title Issue 205 override field name Allow overriding a field's HTML name May 31, 2020
@davidism davidism merged commit 3149b38 into pallets-eco:master May 31, 2020
@azmeuk azmeuk mentioned this pull request Oct 4, 2020
Closed
@azmeuk azmeuk deleted the issue-205-override-field-name branch October 6, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidism davidism davidism approved these changes

Assignees

No one assigned

Labels

enhancement New feature, or existing feature improvement

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Override field's name attribute?

2 participants

@azmeuk @davidism