Re-introduce Choice and SelectChoice dataclasses#889
Merged
Conversation
This was
linked to
issues
May 3, 2026
azmeuk
added
enhancement
Closed
Choices can now be passed as Choice/SelectChoice instances, which provides stronger typing, more explicit arguments and simpler code. - passing choices as tuples is deprecated - passing optgroups as a dict is deprecated - <option> HTML attributes can be set via Choice.render_kw - empty <optgroup> elements are no longer rendered
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ChoiceandSelectChoicedataclasses were introduced in #739 to solve #692, but have been deleted by error in the same PR in a messy force-push.I cherry-picked the old commit. To summarize,
SelectFieldandRadioGroupchoice parameter now take aChoiceorSelectChoiceinstance instead of tuples. To summarize:<option>HTML attributes can be set viaChoice.render_kw<optgroup>elements are no longer renderediter_choicesreturnChoiceinstead of tuplesrender_optiontakes a choice instead ofvalue, label, selected, **kwargs