AI junk - #3725
Closed
Cyriellewu wants to merge 1 commit into
Closed
Conversation
The base Parameter.make_metavar only appended '...' when nargs != 1, so an option with multiple=True (which keeps nargs=1) rendered an identical metavar to a single-value option. Append '...' when self.multiple as well, so help output signals the option can be repeated (e.g. '--foo TEXT...'). Closes pallets#3652 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3652.
Problem
An option declared with
multiple=Truerenders a metavar identical to a single-value option, so--helpgives the user no signal that it can be repeated.Cause
The base
Parameter.make_metavaronly appends...whennargs != 1.multiple=Truekeepsnargs == 1, so the ellipsis was never added.Fix
Append
...whenself.multipleas well: