Repository navigation
fix(web): drag preview opens no blank gaps under folded groups - #234
Conversation
- Collapsed Active hides its rows, so the drag preview opens no empty-Active slot - The empty-Active hint counts the Active group only, so with custom groups the opened slot shows it
The dragged row folds away on drop, so only the open thread (which stays visible) opens a slot there. Count Active-group threads only where the hint renders.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe sidebar drag strategy now accounts for folded groups, route-thread visibility, and the Active shelf state. The Active drop hint uses ungrouped Active threads. Tests cover drag projections for expanded and folded groups. ChangesFold-aware sidebar dragging
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The reviewed drag-preview behavior presents no identified obstacle to merging after normal checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dragging a sidebar thread opened blank space under group headers below the pins. The drag preview treated a folded Active as empty and reserved its empty-Active placeholder slot, which stayed blank. Hovering a folded group's header also opened a card-sized slot under it, but the row folds away on drop. With custom groups, an expanded but empty Active opened the placeholder slot without its hint, because the hint counted every active thread rather than just the Active group's.
foldedGroupIds(null = Active). A folded group opens no slot for the dragged row unless it is the open thread, which stays visible in folded groups. A folded Active opens no placeholder. The header stays the drop target.The Pinned-label and gap-under-pins issues seen in the installed Dev app come from a build older than #227. They do not reproduce on
dev.Verified in a dev build seeded with real data and thread groups: a collapsed Active shows no gap, a folded custom group header opens no slot when hovered, an empty expanded Active shows its hint, and pinned drags show no extra label or gap.
Opus 5.5 via Claude Code