Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Remove old migrations - #2040

Merged
paritytech-processbot[bot] merged 2 commits into
masterfrom
gav-rm-inactive-tracking-migrations
Jan 11, 2023
Merged

Remove old migrations#2040
paritytech-processbot[bot] merged 2 commits into
masterfrom
gav-rm-inactive-tracking-migrations

Conversation

@gavofyork

@gavofyork gavofyork commented Dec 23, 2022

Copy link
Copy Markdown
Member

Do not merge until all runtimes have already been upgraded to include the migrations.

@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Dec 23, 2022
@paritytech-ci
paritytech-ci requested review from a team December 23, 2022 15:23
@gavofyork gavofyork added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 27, 2022
@gavofyork

gavofyork commented Dec 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@joepetrowski please merge this once the CGPs have been upgraded with these migrations enabled.

@joepetrowski

joepetrowski commented Dec 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

These got applied in 9330, and we removed them in 9360 in #2031 I missed Contracts, but once these backports make it to master I'll resolve this branch.

@bkchr

ghost commented Jan 11, 2023

Copy link
Copy Markdown
Member

@joepetrowski we actually need to change the pr to do the same as in Polkadot: https://github.com/paritytech/polkadot/blob/7f3a6e10068938f758d44fed548473b9e2a9893b/runtime/polkadot/src/lib.rs#L1604-L1606

@joepetrowski

ghost commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Do we? paritytech/polkadot#6471 mentions "only runtimes that have crowdloan", and paritytech/substrate#13009 only affects Treasury. But the migrations in Statemint/Contracts only affected the XCM Check Account.

@bkchr

ghost commented Jan 11, 2023

Copy link
Copy Markdown
Member

Do we? paritytech/polkadot#6471 mentions "only runtimes that have crowdloan", and paritytech/substrate#13009 only affects Treasury. But the migrations in Statemint/Contracts only affected the XCM Check Account.

Yeah good points!

@paritytech-ci
paritytech-ci requested a review from a team January 11, 2023 15:07
ruseinov
ruseinov reviewed Jan 11, 2023
View reviewed changes
Comment thread parachains/runtimes/contracts/contracts-rococo/src/lib.rs
pallet_contracts::Migration<Runtime>,
pallet_balances::migration::MigrateToTrackInactive<Runtime, xcm_config::CheckingAccount>,
);
pub type Migrations = (pallet_contracts::Migration<Runtime>,);

ghost Jan 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this hasn't been executed, yet

ruseinov
ruseinov approved these changes Jan 11, 2023
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@joepetrowski

ghost commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

bot merge

@paritytech-processbot
paritytech-processbot Bot merged commit e949f21 into master Jan 11, 2023
@paritytech-processbot
paritytech-processbot Bot deleted the gav-rm-inactive-tracking-migrations branch January 11, 2023 18:29
This was referenced Feb 22, 2023
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 23, 2023
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@muharem muharem Awaiting requested review from muharem
@tonyalaribe tonyalaribe Awaiting requested review from tonyalaribe
3 more reviewers
@ruseinov ruseinov ruseinov approved these changes
@bkchr bkchr bkchr approved these changes
@sandreim sandreim sandreim approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

Runtime / FRAME
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gavofyork @joepetrowski @bkchr @ruseinov @sandreim