You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Improve election pallet testing setup and checks #12184
Recently, we added some events to some of the tests in pallet-election-provider-multi-phase.
This is generally a good patterns and I want all tests to basically finish with an assertion over the events that got fired during the tests. The author should verify that the events are sensible to the best of their abilities.
Lastly, in some experimental work, I've replaced all of the roll_to(x) to roll_to_eventName. We want all tests to use this pattern as well, for less breaking changes.
For example, almost all of the cases where we roll_to(15), we want to roll_to_unsigned().
Activity
Szegoo commentedon Sep 21, 2022
I will give this a try.