Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Investigate failing Pallet UI tests #12955

Closed

Description

@ggwpez

The pallet UI tests sometimes fail with just one line of diff. It often looks like this:

@@ -28,7 +28,7 @@ error[E0277]: the trait bound `Bar: EncodeLike` is not satisfied
              <&[(T,)] as EncodeLike<BinaryHeap<LikeT>>>
              <&[(T,)] as EncodeLike<LinkedList<LikeT>>>
              <&[T] as EncodeLike<Vec<U>>>
-           and 278 others
+           and 279 others
    = note: required for `Bar` to implement `FullEncode`
    = note: required for `Bar` to implement `FullCodec`
    = note: required for `frame_support::pallet_prelude::StorageValue<_GeneratedPrefixForStorageFoo<T>, Bar>` to implement `PartialStorageInfoTrait`

Example include #12485 and #12537 (search for pallet_ui in the files).
No idea what is causing this, but I had it at least three times now.

Activity

  1. added
    I4-annoyanceThe client behaves within expectations, however this “expected behaviour” itself is at issue.
    on Dec 16, 2022
  2. moved this to Backlog in Runtime / FRAMEon Dec 16, 2022
  3. bkchr commented on Dec 16, 2022

    @bkchr
    Member

    Hmm and how did you solve these errors? Did you rerun the tests with TRYBUILD=overwrite?

  4. ggwpez commented on Dec 16, 2022

    @ggwpez
    MemberAuthor

    Did you rerun the tests with TRYBUILD=overwrite?

    Yes it was "solved" with your update-rust-stable.sh script.

  5. bkchr commented on Dec 16, 2022

    @bkchr
    Member

    Looks like that the number between both tests increased by one. So, maybe some new type that is implemented in these prs that make this number go up? Which is clearly annoying.

  6. hirschenberger commented on Jan 5, 2023

    @hirschenberger
    Contributor

    I did some research and this seems to be resolved in trybuild since 1.0.70 with dtolnay/trybuild#198.
    I think an update may solve the issue.

  7. added 2 commits that reference this issue on Jan 5, 2023
    a974556
    c6e86ff
  8. added a commit that references this issue on Jan 6, 2023
    bc73ebf
  9. added a commit that references this issue on Feb 22, 2023
    bc3e2eb
  10. added a commit that references this issue on Feb 27, 2023
    a7082ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    I4-annoyanceThe client behaves within expectations, however this “expected behaviour” itself is at issue.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions