Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

T::AccountId used over <T::Lookup as StaticLookup>::Source in dispatchable calls #6042

Closed
#11670
Closed
T::AccountId used over <T::Lookup as StaticLookup>::Source in dispatchable calls#6042
#11670
Labels
I7-refactorCode needs refactoring.J0-enhancementAn additional feature request.Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coderZ6-mentorAn easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Description

@xlc
xlc
opened on May 15, 2020

Substrate still have many T::AccountId in dispatchable call parameters. I think they should all be replaced by <T::Lookup as StaticLookup>::Source

This is results from a quick regex \(origin, (.*): T::AccountId

Screen Shot 2020-05-15 at 5 23 22 PM

Activity

  1. shawntabrizi commented on May 20, 2020

    @shawntabrizi
    shawntabrizi
    on May 20, 2020
    Member

    We brought this up internally in the past. Yes it should be done, but it was not a high priority. This could be a great first issue for anyone to pick up :)

    happy to mentor

  2. shawntabrizi
    added
    I7-refactorCode needs refactoring.
    J0-enhancementAn additional feature request.
    Z6-mentorAn easy task where a mentor is available. Please indicate in the issue who the mentor could be.
    on May 20, 2020

  3. ltfschoen commented on Jul 11, 2020

    @ltfschoen
    ltfschoen
    on Jul 11, 2020
    Contributor

    I've had a go at this and created this WIP PR, which includes some questions. #6637

  4. herou commented on Sep 2, 2020

    @herou
    herou
    on Sep 2, 2020

    Is this ticket still available?

  5. jaxter03 commented on Nov 19, 2020

    @jaxter03
    jaxter03
    on Nov 19, 2020
    Contributor

    @shawntabrizi is this issue available?

  6. shawntabrizi commented on Nov 19, 2020

    @shawntabrizi
    shawntabrizi
    on Nov 19, 2020
    Member

    @ksr30 you can do it

  7. jaxter03 commented on Nov 19, 2020

    @jaxter03
    jaxter03
    on Nov 19, 2020
    Contributor

    Thanks @shawntabrizi

  8. shawntabrizi
    added
    Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coder
    on Dec 10, 2020

  9. shamb0 commented on Jan 7, 2021

    @shamb0
    shamb0
    on Jan 7, 2021
    Contributor

    Hello @shawntabrizi , if its open shall I pick it up

  10. Doordashcon commented on Jun 14, 2022

    @Doordashcon
    Doordashcon
    on Jun 14, 2022
    Contributor

    Is this still a needed task to solve @shawntabrizi?

  11. bkchr commented on Jun 14, 2022

    @bkchr
    bkchr
    on Jun 14, 2022
    Member

    Yes, looks like their is still stuff to do.

  12. paritytech-processbot
    closed this as completedin #11670on Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    I7-refactorCode needs refactoring.J0-enhancementAn additional feature request.Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coderZ6-mentorAn easy task where a mentor is available. Please indicate in the issue who the mentor could be.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions