Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Use 'Items' and 'Collections' in uniques pallet - #11389

Merged
paritytech-processbot[bot] merged 18 commits into
masterfrom
js/uniques-renamings
May 16, 2022
Merged

paritytech-processbot[bot] merged 18 commits into
masterfrom
js/uniques-renamings

Conversation

@jsidorenko

@jsidorenko jsidorenko commented May 10, 2022 •

Copy link
Copy Markdown
Contributor

This PR renames classes and instances to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.

Cumulus Companion: paritytech/cumulus#1256

@jsidorenko jsidorenko added the A0-please_review Pull request needs code review. label May 10, 2022
@jsidorenko
jsidorenko requested a review from shawntabrizi May 10, 2022 16:54
Comment thread frame/uniques/src/lib.rs
@jsidorenko jsidorenko changed the title Use 'Assets' and 'Collections' in uniques pallet Use 'Items' and 'Collections' in uniques pallet May 10, 2022
Comment thread frame/uniques/src/benchmarking.rs Outdated
Comment thread frame/uniques/src/lib.rs Outdated
@shawntabrizi shawntabrizi added B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 12, 2022
@shawntabrizi

Copy link
Copy Markdown
Member

/benchmark runtime pallet pallet_uniques

@ghost

ghost commented May 12, 2022 •

Copy link
Copy Markdown

Benchmark Runtime Pallet for branch "js/uniques-renamings" with command cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.60.0 (7737e0b5c 2022-04-04)

Results
error: failed to run custom build command for `node-runtime v3.0.0-dev (/home/benchbot/bench-bot/git/substrate/bin/node/runtime)`

Caused by:
  process didn't exit successfully: `/home/benchbot/bench-bot/git/substrate/target/production/build/node-runtime-cf2314b18dc2b62c/build-script-build` (exit status: 1)
  --- stdout
  �[1;33mInformation that should be included in a bug report.�[0m
  �[1;33mExecuting build command:�[0m "rustup" "run" "nightly" "cargo" "rustc" "--target=wasm32-unknown-unknown" "--manifest-path=/home/benchbot/bench-bot/git/substrate/target/production/wbuild/node-runtime/Cargo.toml" "--color=always" "--profile" "production"
  �[1;33mUsing rustc version:�[0m rustc 1.62.0-nightly (cb1219871 2022-05-08)


  --- stderr
  �[0m�[1m�[33mwarning�[0m�[0m�[1m: unused import: `alloc::string::ToString`�[0m
  �[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/frame/contracts/proc-macro/src/lib.rs:24:5�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m24�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0muse alloc::string::ToString;�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    �[0m�[0m�[1m�[33m^^^^^^^^^^^^^^^^^^^^^^^�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mnote�[0m�[0m: `#[warn(unused_imports)]` on by default�[0m

  �[0m�[1m�[33mwarning�[0m�[0m�[1m: unused imports: `DataStruct`, `Fields`�[0m
  �[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/frame/contracts/proc-macro/src/lib.rs:27:54�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m27�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0muse syn::{parse_macro_input, spanned::Spanned, Data, DataStruct, DeriveInput, Fields, Ident};�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                                                     �[0m�[0m�[1m�[33m^^^^^^^^^^�[0m�[0m               �[0m�[0m�[1m�[33m^^^^^^�[0m

  �[0m�[1m�[33mwarning�[0m�[0m�[1m: unused import: `spanned::Spanned`�[0m
  �[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/frame/contracts/proc-macro/src/lib.rs:27:30�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m27�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0muse syn::{parse_macro_input, spanned::Spanned, Data, DataStruct, DeriveInput, Fields, Ident};�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                             �[0m�[0m�[1m�[33m^^^^^^^^^^^^^^^^�[0m

  �[0m�[0m�[1m�[33mwarning�[0m�[1m:�[0m `pallet-contracts-proc-macro` (lib) generated 3 warnings
  �[0m�[1m�[33mwarning�[0m�[0m�[1m: unnecessary lifetime parameter `'a`�[0m
  �[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/primitives/runtime/src/curve.rs:28:28�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m28�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0mpub struct PiecewiseLinear<'a> {�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[33m^^�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mhelp�[0m�[0m: you can use the `'static` lifetime directly, in place of `'a`�[0m

  �[0m�[0m�[1m�[33mwarning�[0m�[1m:�[0m `sp-runtime` (lib) generated 1 warning
  �[0m�[1m�[33mwarning�[0m�[0m�[1m: function is never used: `has_api_with`�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/primitives/version/src/lib.rs:276:4�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m276�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0mfn has_api_with<P: Fn(u32) -> bool>(apis: &ApisVec, id: &ApiId, predicate: P) -> bool {�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m   �[0m�[0m�[1m�[33m^^^^^^^^^^^^�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mnote�[0m�[0m: `#[warn(dead_code)]` on by default�[0m

  �[0m�[0m�[1m�[33mwarning�[0m�[1m:�[0m `sp-version` (lib) generated 1 warning
  �[0m�[0m�[1m�[32m   Compiling�[0m sp-staking v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/primitives/staking)
  �[0m�[0m�[1m�[32m   Compiling�[0m frame-support v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/support)
  �[0m�[1m�[33mwarning�[0m�[0m�[1m: unnecessary lifetime parameter `'a`�[0m
  �[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/frame/support/src/storage/bounded_vec.rs:49:25�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m49�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0mpub struct BoundedSlice<'a, T, S>(&'a [T], PhantomData<S>);�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                        �[0m�[0m�[1m�[33m^^�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mhelp�[0m�[0m: you can use the `'static` lifetime directly, in place of `'a`�[0m

  �[0m�[0m�[1m�[32m   Compiling�[0m sp-session v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/primitives/session)
  �[0m�[1m�[33mwarning�[0m�[0m�[1m: unused import: `legacy::byte_sized_error::ApplyExtrinsicResult as ApplyExtrinsicResultBeforeV6`�[0m
  �[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/primitives/block-builder/src/lib.rs:24:2�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m24�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    legacy::byte_sized_error::ApplyExtrinsicResult as ApplyExtrinsicResultBeforeV6,�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    �[0m�[0m�[1m�[33m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mnote�[0m�[0m: `#[warn(unused_imports)]` on by default�[0m

  �[0m�[0m�[1m�[33mwarning�[0m�[1m:�[0m `sp-block-builder` (lib) generated 1 warning
  �[0m�[0m�[1m�[33mwarning�[0m�[1m:�[0m `frame-support` (lib) generated 1 warning
  �[0m�[0m�[1m�[32m   Compiling�[0m frame-system v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/system)
  �[0m�[0m�[1m�[32m   Compiling�[0m frame-try-runtime v0.10.0-dev (/home/benchbot/bench-bot/git/substrate/frame/try-runtime)
  �[0m�[1m�[33mwarning�[0m�[0m�[1m: unused import: `sp_std::prelude::*`�[0m
  �[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/frame/try-runtime/src/lib.rs:23:5�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m23�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0muse sp_std::prelude::*;�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    �[0m�[0m�[1m�[33m^^^^^^^^^^^^^^^^^^�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mnote�[0m�[0m: `#[warn(unused_imports)]` on by default�[0m

  �[0m�[0m�[1m�[33mwarning�[0m�[1m:�[0m `frame-try-runtime` (lib) generated 1 warning
  �[0m�[0m�[1m�[32m   Compiling�[0m frame-benchmarking v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/benchmarking)
  �[0m�[0m�[1m�[32m   Compiling�[0m frame-election-provider-support v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/election-provider-support)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-authorship v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/authorship)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-transaction-payment v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/transaction-payment)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-nomination-pools v1.0.0 (/home/benchbot/bench-bot/git/substrate/frame/nomination-pools)
  �[0m�[1m�[33mwarning�[0m�[0m�[1m: unused import: `PartialEqNoBound`�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/frame/nomination-pools/src/lib.rs:319:32�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m319�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    CloneNoBound, DefaultNoBound, PartialEqNoBound, RuntimeDebugNoBound,�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                                  �[0m�[0m�[1m�[33m^^^^^^^^^^^^^^^^�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mnote�[0m�[0m: `#[warn(unused_imports)]` on by default�[0m

  �[0m�[0m�[1m�[33mwarning�[0m�[1m:�[0m `pallet-nomination-pools` (lib) generated 1 warning
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-randomness-collective-flip v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/randomness-collective-flip)
  �[0m�[0m�[1m�[32m   Compiling�[0m frame-executive v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/executive)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-sudo v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/sudo)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-society v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/society)
  �[0m�[0m�[1m�[32m   Compiling�[0m node-primitives v2.0.0 (/home/benchbot/bench-bot/git/substrate/bin/node/primitives)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-balances v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/balances)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-timestamp v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/timestamp)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-whitelist v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/whitelist)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-contracts v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/contracts)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-assets v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/assets)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-conviction-voting v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/conviction-voting)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-lottery v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/lottery)
  �[0m�[0m�[1m�[32m   Compiling�[0m frame-system-benchmarking v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/system/benchmarking)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-scheduler v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/scheduler)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-vesting v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/vesting)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-preimage v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/preimage)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-utility v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/utility)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-membership v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/membership)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-democracy v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/democracy)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-indices v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/indices)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-proxy v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/proxy)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-remark v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/remark)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-uniques v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/uniques)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-gilt v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/gilt)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-referenda v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/referenda)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-elections-phragmen v5.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/elections-phragmen)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-state-trie-migration v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/state-trie-migration)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-mmr v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/merkle-mountain-range)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-recovery v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/recovery)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-multisig v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/multisig)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-identity v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/identity)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-collective v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/collective)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-election-provider-multi-phase v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/election-provider-multi-phase)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-election-provider-support-benchmarking v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/election-provider-support/benchmarking)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-im-online v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/im-online)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-transaction-payment-rpc-runtime-api v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/transaction-payment/rpc/runtime-api)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-asset-tx-payment v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/transaction-payment/asset-tx-payment)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-treasury v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/treasury)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-offences v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/offences)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-bags-list v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/bags-list)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-transaction-storage v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/transaction-storage)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-session v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/session)
  �[0m�[1m�[33mwarning�[0m�[0m�[1m: associated function is never used: `sanity_check`�[0m
  �[0m   �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/frame/bags-list/src/list/mod.rs:788:5�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m788�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    fn sanity_check(&self) -> Result<(), &'static str> {�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m       �[0m�[0m�[1m�[33m^^^^^^^^^^^^�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mnote�[0m�[0m: `#[warn(dead_code)]` on by default�[0m

  �[0m�[0m�[1m�[33mwarning�[0m�[1m:�[0m `pallet-bags-list` (lib) generated 1 warning
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-bounties v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/bounties)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-tips v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/tips)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-child-bounties v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/child-bounties)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-staking v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/staking)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-babe v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/babe)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-grandpa v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/grandpa)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-authority-discovery v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/authority-discovery)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-offences-benchmarking v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/offences/benchmarking)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-nomination-pools-benchmarking v1.0.0 (/home/benchbot/bench-bot/git/substrate/frame/nomination-pools/benchmarking)
  �[0m�[0m�[1m�[32m   Compiling�[0m pallet-session-benchmarking v4.0.0-dev (/home/benchbot/bench-bot/git/substrate/frame/session/benchmarking)
  �[0m�[0m�[1m�[32m   Compiling�[0m node-runtime v3.0.0-dev (/home/benchbot/bench-bot/git/substrate/bin/node/runtime)
  �[0m�[1m�[38;5;9merror[E0437]�[0m�[0m�[1m: type `ClassId` is not a member of trait `pallet_uniques::Config`�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/bin/node/runtime/src/lib.rs:1417:2�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m1417�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    type ClassId = u32;�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    �[0m�[0m�[1m�[38;5;9m^^^^^^^^^^^^^^^^^^^�[0m�[0m �[0m�[0m�[1m�[38;5;9mnot a member of trait `pallet_uniques::Config`�[0m

  �[0m�[1m�[38;5;9merror[E0437]�[0m�[0m�[1m: type `InstanceId` is not a member of trait `pallet_uniques::Config`�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/bin/node/runtime/src/lib.rs:1418:2�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m1418�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    type InstanceId = u32;�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    �[0m�[0m�[1m�[38;5;9m^^^^^^^^^^^^^^^^^^^^^^�[0m�[0m �[0m�[0m�[1m�[38;5;9mnot a member of trait `pallet_uniques::Config`�[0m

  �[0m�[1m�[38;5;9merror[E0437]�[0m�[0m�[1m: type `ClassDeposit` is not a member of trait `pallet_uniques::Config`�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/bin/node/runtime/src/lib.rs:1421:2�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m1421�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    type ClassDeposit = ClassDeposit;�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    �[0m�[0m�[1m�[38;5;9m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m�[0m �[0m�[0m�[1m�[38;5;9mnot a member of trait `pallet_uniques::Config`�[0m

  �[0m�[1m�[38;5;9merror[E0437]�[0m�[0m�[1m: type `InstanceDeposit` is not a member of trait `pallet_uniques::Config`�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/bin/node/runtime/src/lib.rs:1422:2�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m1422�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    type InstanceDeposit = InstanceDeposit;�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m| �[0m�[0m    �[0m�[0m�[1m�[38;5;9m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m�[0m �[0m�[0m�[1m�[38;5;9mnot a member of trait `pallet_uniques::Config`�[0m

  �[0m�[1m�[38;5;9merror[E0046]�[0m�[0m�[1m: not all trait items implemented, missing: `CollectionId`, `ItemId`, `CollectionDeposit`, `ItemDeposit`�[0m
  �[0m    �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/benchbot/bench-bot/git/substrate/bin/node/runtime/src/lib.rs:1415:1�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m�[1m�[38;5;12m1415�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0mimpl pallet_uniques::Config for Runtime {�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;9m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m�[0m �[0m�[0m�[1m�[38;5;9mmissing `CollectionId`, `ItemId`, `CollectionDeposit`, `ItemDeposit` in implementation�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mhelp�[0m�[0m: �[0m�[0mimplement the missing item: `type CollectionId = Type;`�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mhelp�[0m�[0m: �[0m�[0mimplement the missing item: `type ItemId = Type;`�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mhelp�[0m�[0m: �[0m�[0mimplement the missing item: `type CollectionDeposit = Type;`�[0m
  �[0m     �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mhelp�[0m�[0m: �[0m�[0mimplement the missing item: `type ItemDeposit = Type;`�[0m

  �[0m�[1mSome errors have detailed explanations: E0046, E0437.�[0m
  �[0m�[1mFor more information about an error, try `rustc --explain E0046`.�[0m
  �[0m�[0m�[1m�[31merror�[0m�[1m:�[0m could not compile `node-runtime` due to 5 previous errors
error: build failed

ERROR: Unable to commit file ./frame/uniques/src/weights.rs

@jsidorenko
jsidorenko requested a review from ggwpez May 12, 2022 16:31
@jsidorenko

Copy link
Copy Markdown
Contributor Author

/benchmark runtime pallet pallet_uniques

@ghost

ghost commented May 12, 2022 •

Copy link
Copy Markdown

Benchmark Runtime Pallet for branch "js/uniques-renamings" with command cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.60.0 (7737e0b5c 2022-04-04)

Results
Pallet: "pallet_uniques", Extrinsic: "create", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques ClassAccount (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.73
              µs

Reads = 1
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.73
              µs

Reads = 1
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "force_create", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques ClassAccount (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.33
              µs

Reads = 1
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.33
              µs

Reads = 1
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "destroy", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques Instance (r:1 w:0)
Storage: Uniques ClassAccount (r:0 w:1)
Storage: Uniques Attribute (r:0 w:1000)
Storage: Uniques ClassMetadataOf (r:0 w:1)
Storage: Uniques InstanceMetadataOf (r:0 w:1000)
Storage: Uniques Account (r:0 w:20)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + n    9.343
    + m    1.063
    + a     0.89
              µs

Reads = 2 + (1 * n) + (0 * m) + (0 * a)
Writes = 3 + (2 * n) + (1 * m) + (1 * a)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    n     m     a   mean µs  sigma µs       %
    0  1000  1000      1523     13.43    0.8%
   20  1000  1000      1691     8.656    0.5%
   40  1000  1000      1872        14    0.7%
   60  1000  1000      2042     10.64    0.5%
   80  1000  1000      2203     13.25    0.6%
  100  1000  1000      2396     13.86    0.5%
  120  1000  1000      2574     18.02    0.6%
  140  1000  1000      2729     16.66    0.6%
  160  1000  1000      2874     10.15    0.3%
  180  1000  1000      3059     12.57    0.4%
  200  1000  1000      3261     9.667    0.2%
  220  1000  1000      3419        17    0.4%
  240  1000  1000      3623     13.15    0.3%
  260  1000  1000      3816     7.811    0.2%
  280  1000  1000      4010     22.01    0.5%
  300  1000  1000      4178     16.66    0.3%
  320  1000  1000      4296     22.88    0.5%
  340  1000  1000      4516     14.25    0.3%
  360  1000  1000      4750     22.37    0.4%
  380  1000  1000      4923     22.02    0.4%
  400  1000  1000      5020     19.89    0.3%
  420  1000  1000      5279      14.3    0.2%
  440  1000  1000      5422     15.44    0.2%
  460  1000  1000      5855     206.3    3.5%
  480  1000  1000      5847     23.98    0.4%
  500  1000  1000      6042     26.07    0.4%
  520  1000  1000      6247     26.86    0.4%
  540  1000  1000      6366     20.32    0.3%
  560  1000  1000      6624     10.58    0.1%
  580  1000  1000      6856     27.79    0.4%
  600  1000  1000      6812        18    0.2%
  620  1000  1000      7236     29.77    0.4%
  640  1000  1000      7478     13.93    0.1%
  660  1000  1000      7443     18.04    0.2%
  680  1000  1000      7804     29.42    0.3%
  700  1000  1000      8041     38.23    0.4%
  720  1000  1000      8032     17.85    0.2%
  740  1000  1000      8326     28.34    0.3%
  760  1000  1000      8368      31.2    0.3%
  780  1000  1000      8726      18.8    0.2%
  800  1000  1000      8819     24.99    0.2%
  820  1000  1000      9138     61.41    0.6%
  840  1000  1000      9328      36.3    0.3%
  860  1000  1000      9168     22.36    0.2%
  880  1000  1000      9567     50.27    0.5%
  900  1000  1000      9941     36.28    0.3%
  920  1000  1000     10160     47.97    0.4%
  940  1000  1000     10250     36.58    0.3%
  960  1000  1000     10140     38.76    0.3%
  980  1000  1000     10660     38.84    0.3%
 1000     0  1000      9766     41.49    0.4%
 1000    20  1000      9884     41.36    0.4%
 1000    40  1000      9819     28.68    0.2%
 1000    60  1000     10040     36.51    0.3%
 1000    80  1000     10080      32.6    0.3%
 1000   100  1000     10070     18.39    0.1%
 1000   120  1000      9974     28.48    0.2%
 1000   140  1000      9784     29.96    0.3%
 1000   160  1000      9761     31.29    0.3%
 1000   180  1000     10230     38.53    0.3%
 1000   200  1000     10080     29.15    0.2%
 1000   220  1000      9885     37.38    0.3%
 1000   240  1000     10350     51.87    0.5%
 1000   260  1000     10200     32.48    0.3%
 1000   280  1000     10220     23.77    0.2%
 1000   300  1000     10210     28.97    0.2%
 1000   320  1000     10360     44.08    0.4%
 1000   340  1000     10250     34.43    0.3%
 1000   360  1000     10310     42.05    0.4%
 1000   380  1000     10100      26.9    0.2%
 1000   400  1000     10200     36.19    0.3%
 1000   420  1000     10260     38.99    0.3%
 1000   440  1000     10160     28.17    0.2%
 1000   460  1000     10210      37.2    0.3%
 1000   480  1000     10570     26.75    0.2%
 1000   500  1000     10290     22.46    0.2%
 1000   520  1000     10200     41.39    0.4%
 1000   540  1000     10490     42.91    0.4%
 1000   560  1000     10520     29.07    0.2%
 1000   580  1000     10530     41.92    0.3%
 1000   600  1000     10310     28.29    0.2%
 1000   620  1000     10640     60.52    0.5%
 1000   640  1000     10480     39.93    0.3%
 1000   660  1000     10680     33.07    0.3%
 1000   680  1000     10620     42.15    0.3%
 1000   700  1000     10750     17.78    0.1%
 1000   720  1000     10770     43.06    0.3%
 1000   740  1000     10680      33.7    0.3%
 1000   760  1000     10400     31.39    0.3%
 1000   780  1000     10650     35.38    0.3%
 1000   800  1000     10440     50.21    0.4%
 1000   820  1000     10870     31.95    0.2%
 1000   840  1000     10840     48.22    0.4%
 1000   860  1000     10670     32.58    0.3%
 1000   880  1000     10690     45.94    0.4%
 1000   900  1000     10850     45.75    0.4%
 1000   920  1000     10990     39.87    0.3%
 1000   940  1000     10850     53.58    0.4%
 1000   960  1000     10750     50.34    0.4%
 1000   980  1000     10630      23.2    0.2%
 1000  1000     0     10090     49.38    0.4%
 1000  1000    20     10020     18.62    0.1%
 1000  1000    40      9979     17.29    0.1%
 1000  1000    60     10010     28.23    0.2%
 1000  1000    80     10160     33.27    0.3%
 1000  1000   100     10120      47.4    0.4%
 1000  1000   120     10030     26.22    0.2%
 1000  1000   140      9816     28.33    0.2%
 1000  1000   160     10270     24.64    0.2%
 1000  1000   180     10210     32.46    0.3%
 1000  1000   200     10160     31.96    0.3%
 1000  1000   220     10100     44.89    0.4%
 1000  1000   240      9944     46.51    0.4%
 1000  1000   260     10180     39.84    0.3%
 1000  1000   280     10380     34.29    0.3%
 1000  1000   300     10360     21.64    0.2%
 1000  1000   320     10410     15.54    0.1%
 1000  1000   340     10400     33.93    0.3%
 1000  1000   360     10220     38.14    0.3%
 1000  1000   380     10500     42.45    0.4%
 1000  1000   400     10290     25.45    0.2%
 1000  1000   420     10430     41.92    0.4%
 1000  1000   440     10120     56.12    0.5%
 1000  1000   460     10460     46.89    0.4%
 1000  1000   480     10100     38.66    0.3%
 1000  1000   500     10190     26.66    0.2%
 1000  1000   520     10460     35.23    0.3%
 1000  1000   540     10520      28.1    0.2%
 1000  1000   560     10470      39.4    0.3%
 1000  1000   580     10620     43.32    0.4%
 1000  1000   600     10340     33.45    0.3%
 1000  1000   620     10620     36.46    0.3%
 1000  1000   640     10340     61.76    0.5%
 1000  1000   660     10620     35.19    0.3%
 1000  1000   680     10720     44.42    0.4%
 1000  1000   700     10700     23.83    0.2%
 1000  1000   720     10550     46.78    0.4%
 1000  1000   740     10560     22.42    0.2%
 1000  1000   760     10460     35.18    0.3%
 1000  1000   780     10460     27.24    0.2%
 1000  1000   800     10920      22.7    0.2%
 1000  1000   820     10690     51.77    0.4%
 1000  1000   840     10600      27.8    0.2%
 1000  1000   860     10640     24.79    0.2%
 1000  1000   880     10470     42.63    0.4%
 1000  1000   900     10970     41.22    0.3%
 1000  1000   920     10830     44.91    0.4%
 1000  1000   940     11000     34.56    0.3%
 1000  1000   960     10760     34.37    0.3%
 1000  1000   980     10650      45.8    0.4%
 1000  1000  1000     11040     48.04    0.4%

Quality and confidence:
param     error
n         0.014
m         0.014
a         0.014

Model:
Time ~=        0
    + n    9.463
    + m    0.928
    + a    0.835
              µs

Reads = 2 + (1 * n) + (0 * m) + (0 * a)
Writes = 3 + (2 * n) + (1 * m) + (1 * a)

Pallet: "pallet_uniques", Extrinsic: "mint", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Instance (r:1 w:1)
Storage: Uniques Class (r:1 w:1)
Storage: Uniques Account (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    29.84
              µs

Reads = 2
Writes = 3

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    29.84
              µs

Reads = 2
Writes = 3

Pallet: "pallet_uniques", Extrinsic: "burn", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques Instance (r:1 w:1)
Storage: Uniques Account (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    31.66
              µs

Reads = 2
Writes = 3

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    31.66
              µs

Reads = 2
Writes = 3

Pallet: "pallet_uniques", Extrinsic: "transfer", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:0)
Storage: Uniques Instance (r:1 w:1)
Storage: Uniques Account (r:0 w:2)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.54
              µs

Reads = 2
Writes = 3

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.54
              µs

Reads = 2
Writes = 3

Pallet: "pallet_uniques", Extrinsic: "redeposit", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques Instance (r:100 w:100)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + i    11.69
              µs

Reads = 1 + (1 * i)
Writes = 1 + (1 * i)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    i   mean µs  sigma µs       %
    0     14.68     0.094    0.6%
  100      1055     7.775    0.7%
  200      2125     10.41    0.4%
  300      3192     13.46    0.4%
  400      4275     7.471    0.1%
  500      5452     31.79    0.5%
  600      6455     17.24    0.2%
  700      7611     28.06    0.3%
  800      8695     24.71    0.2%
  900      9832     19.61    0.1%
 1000     10870     28.93    0.2%
 1100     11980     20.84    0.1%
 1200     12960     28.22    0.2%
 1300     14350     27.09    0.1%
 1400     15510     56.22    0.3%
 1500     16400     24.01    0.1%
 1600     17680     37.41    0.2%
 1700     18750      27.2    0.1%
 1800     20000     65.09    0.3%
 1900     21200     80.88    0.3%
 2000     22450     60.18    0.2%
 2100     23490      41.8    0.1%
 2200     24710     46.61    0.1%
 2300     25800     44.03    0.1%
 2400     27000     70.74    0.2%
 2500     28060     69.16    0.2%
 2600     29460     34.78    0.1%
 2700     30760     45.77    0.1%
 2800     31320     55.38    0.1%
 2900     32730     62.51    0.1%
 3000     33690     58.95    0.1%
 3100     35090     70.25    0.2%
 3200     36330     89.91    0.2%
 3300     37880     98.54    0.2%
 3400     38620     84.84    0.2%
 3500     40160     68.61    0.1%
 3600     41520     115.7    0.2%
 3700     42670     71.11    0.1%
 3800     44100     92.07    0.2%
 3900     44560      65.1    0.1%
 4000     46300     131.5    0.2%
 4100     47440     88.61    0.1%
 4200     48490     58.71    0.1%
 4300     49980       144    0.2%
 4400     50990     112.8    0.2%
 4500     52700     126.5    0.2%
 4600     52980     102.5    0.1%
 4700     55010     102.9    0.1%
 4800     55650     167.3    0.3%
 4900     57240     101.4    0.1%
 5000     58170     132.7    0.2%

Quality and confidence:
param     error
i         0.011

Model:
Time ~=        0
    + i    11.71
              µs

Reads = 1 + (1 * i)
Writes = 1 + (1 * i)

Pallet: "pallet_uniques", Extrinsic: "freeze", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Instance (r:1 w:1)
Storage: Uniques Class (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.27
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.27
              µs

Reads = 2
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "thaw", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Instance (r:1 w:1)
Storage: Uniques Class (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.26
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.26
              µs

Reads = 2
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "freeze_collection", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.74
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.74
              µs

Reads = 1
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "thaw_collection", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.65
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.65
              µs

Reads = 1
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "transfer_ownership", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques OwnershipAcceptance (r:1 w:1)
Storage: Uniques Class (r:1 w:1)
Storage: Uniques ClassAccount (r:0 w:2)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    20.77
              µs

Reads = 2
Writes = 4

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    20.77
              µs

Reads = 2
Writes = 4

Pallet: "pallet_uniques", Extrinsic: "set_team", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    14.29
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    14.29
              µs

Reads = 1
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "force_item_status", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques ClassAccount (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    16.39
              µs

Reads = 1
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    16.39
              µs

Reads = 1
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "set_attribute", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques InstanceMetadataOf (r:1 w:0)
Storage: Uniques Attribute (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    37.11
              µs

Reads = 3
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    37.11
              µs

Reads = 3
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "clear_attribute", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques InstanceMetadataOf (r:1 w:0)
Storage: Uniques Attribute (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    35.51
              µs

Reads = 3
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    35.51
              µs

Reads = 3
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "set_metadata", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques InstanceMetadataOf (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    29.04
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    29.04
              µs

Reads = 2
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "clear_metadata", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques InstanceMetadataOf (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    29.25
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    29.25
              µs

Reads = 2
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "set_collection_metadata", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques ClassMetadataOf (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    27.86
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    27.86
              µs

Reads = 2
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "clear_collection_metadata", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:0)
Storage: Uniques ClassMetadataOf (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    26.67
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    26.67
              µs

Reads = 2
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "approve_transfer", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:0)
Storage: Uniques Instance (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    19.24
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    19.24
              µs

Reads = 2
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "cancel_approval", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:0)
Storage: Uniques Instance (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    19.08
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    19.08
              µs

Reads = 2
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "set_accept_ownership", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques OwnershipAcceptance (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    16.58
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    16.58
              µs

Reads = 1
Writes = 1


Parity Bot added 2 commits May 12, 2022 17:01
…--manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
Comment thread frame/uniques/src/weights.rs Outdated
@shawntabrizi

Copy link
Copy Markdown
Member

@jsidorenko please don't skip over review comments that mention a mistake :)

@shawntabrizi

Copy link
Copy Markdown
Member

/benchmark runtime pallet pallet_uniques

@ghost

ghost commented May 12, 2022 •

Copy link
Copy Markdown

Benchmark Runtime Pallet for branch "js/uniques-renamings" with command cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.60.0 (7737e0b5c 2022-04-04)

Results
Pallet: "pallet_uniques", Extrinsic: "create", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques ClassAccount (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    24.31
              µs

Reads = 1
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    24.31
              µs

Reads = 1
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "force_create", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques ClassAccount (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.57
              µs

Reads = 1
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.57
              µs

Reads = 1
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "destroy", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques Asset (r:1 w:0)
Storage: Uniques ClassAccount (r:0 w:1)
Storage: Uniques Attribute (r:0 w:1000)
Storage: Uniques ClassMetadataOf (r:0 w:1)
Storage: Uniques InstanceMetadataOf (r:0 w:1000)
Storage: Uniques Account (r:0 w:20)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + n     9.36
    + m    1.048
    + a    0.909
              µs

Reads = 2 + (1 * n) + (0 * m) + (0 * a)
Writes = 3 + (2 * n) + (1 * m) + (1 * a)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    n     m     a   mean µs  sigma µs       %
    0  1000  1000      1524     12.21    0.8%
   20  1000  1000      1676     7.176    0.4%
   40  1000  1000      1851     9.048    0.4%
   60  1000  1000      2015     12.51    0.6%
   80  1000  1000      2161     11.64    0.5%
  100  1000  1000      2368     10.52    0.4%
  120  1000  1000      2532     26.68    1.0%
  140  1000  1000      2695     10.03    0.3%
  160  1000  1000      2861     13.85    0.4%
  180  1000  1000      3015     9.439    0.3%
  200  1000  1000      3245     13.04    0.4%
  220  1000  1000      3349     17.85    0.5%
  240  1000  1000      3555     12.26    0.3%
  260  1000  1000      3770     15.79    0.4%
  280  1000  1000      3872     20.89    0.5%
  300  1000  1000      4152     19.98    0.4%
  320  1000  1000      4361     7.503    0.1%
  340  1000  1000      4422     28.56    0.6%
  360  1000  1000      4627      19.2    0.4%
  380  1000  1000      4829     24.06    0.4%
  400  1000  1000      5054     16.24    0.3%
  420  1000  1000      5245     15.31    0.2%
  440  1000  1000      5384     13.17    0.2%
  460  1000  1000      5610     19.15    0.3%
  480  1000  1000      5773     13.64    0.2%
  500  1000  1000      5975      15.2    0.2%
  520  1000  1000      6152     21.27    0.3%
  540  1000  1000      6335     21.83    0.3%
  560  1000  1000      6583     17.51    0.2%
  580  1000  1000      6838      35.2    0.5%
  600  1000  1000      6921      20.1    0.2%
  620  1000  1000      7082     16.92    0.2%
  640  1000  1000      7385     29.92    0.4%
  660  1000  1000      7595     40.94    0.5%
  680  1000  1000      7718      22.1    0.2%
  700  1000  1000      8017     30.21    0.3%
  720  1000  1000      8128     32.24    0.3%
  740  1000  1000      8284     31.93    0.3%
  760  1000  1000      8607     34.28    0.3%
  780  1000  1000      8613     24.32    0.2%
  800  1000  1000      8616     20.35    0.2%
  820  1000  1000      9175     32.39    0.3%
  840  1000  1000      9311     20.27    0.2%
  860  1000  1000      9513     36.34    0.3%
  880  1000  1000      9398     34.49    0.3%
  900  1000  1000      9711     32.71    0.3%
  920  1000  1000     10070      36.3    0.3%
  940  1000  1000     10130     36.56    0.3%
  960  1000  1000     10390     42.99    0.4%
  980  1000  1000     10670      37.1    0.3%
 1000     0  1000      9780     29.15    0.2%
 1000    20  1000      9566      28.2    0.2%
 1000    40  1000      9596     31.55    0.3%
 1000    60  1000      9809      34.6    0.3%
 1000    80  1000      9946     43.79    0.4%
 1000   100  1000      9963     33.83    0.3%
 1000   120  1000      9849     30.84    0.3%
 1000   140  1000      9942     25.18    0.2%
 1000   160  1000      9725     48.23    0.4%
 1000   180  1000      9898     22.84    0.2%
 1000   200  1000     10630     119.7    1.1%
 1000   220  1000      9963     27.47    0.2%
 1000   240  1000      9900     43.49    0.4%
 1000   260  1000      9946      31.7    0.3%
 1000   280  1000     10330     31.83    0.3%
 1000   300  1000      9886     61.26    0.6%
 1000   320  1000     10290     32.19    0.3%
 1000   340  1000     10080     24.96    0.2%
 1000   360  1000     10130     26.02    0.2%
 1000   380  1000     10200     40.85    0.4%
 1000   400  1000     10250     40.32    0.3%
 1000   420  1000     10150     40.87    0.4%
 1000   440  1000     10120     28.96    0.2%
 1000   460  1000     10340     38.51    0.3%
 1000   480  1000     10210     29.79    0.2%
 1000   500  1000     10320     25.98    0.2%
 1000   520  1000     10430     34.99    0.3%
 1000   540  1000     10350     28.84    0.2%
 1000   560  1000     10290     19.24    0.1%
 1000   580  1000     10490     21.49    0.2%
 1000   600  1000     10600     42.68    0.4%
 1000   620  1000     10350     32.95    0.3%
 1000   640  1000     10550     26.48    0.2%
 1000   660  1000     10410     59.73    0.5%
 1000   680  1000     10360     46.64    0.4%
 1000   700  1000     10710     47.48    0.4%
 1000   720  1000     10260     32.78    0.3%
 1000   740  1000     10500     33.23    0.3%
 1000   760  1000     10370     32.67    0.3%
 1000   780  1000     10310     23.51    0.2%
 1000   800  1000     10380     40.61    0.3%
 1000   820  1000     10570     52.51    0.4%
 1000   840  1000     10630     41.22    0.3%
 1000   860  1000     10810     38.25    0.3%
 1000   880  1000     10790      60.9    0.5%
 1000   900  1000     10540     38.85    0.3%
 1000   920  1000     10910      54.9    0.5%
 1000   940  1000     10460     29.24    0.2%
 1000   960  1000     10620     49.31    0.4%
 1000   980  1000     10800     41.56    0.3%
 1000  1000     0      9845     36.28    0.3%
 1000  1000    20      9766     50.94    0.5%
 1000  1000    40     10170     23.06    0.2%
 1000  1000    60     10150     20.35    0.2%
 1000  1000    80      9665     18.73    0.1%
 1000  1000   100     10200     37.01    0.3%
 1000  1000   120      9791     28.58    0.2%
 1000  1000   140      9884     40.97    0.4%
 1000  1000   160     10120     43.32    0.4%
 1000  1000   180     10130      28.2    0.2%
 1000  1000   200     10160        43    0.4%
 1000  1000   220     10170      23.6    0.2%
 1000  1000   240     10030     36.98    0.3%
 1000  1000   260      9920     39.29    0.3%
 1000  1000   280     10240     24.12    0.2%
 1000  1000   300     10330     44.04    0.4%
 1000  1000   320     10020     27.94    0.2%
 1000  1000   340     10170     28.71    0.2%
 1000  1000   360     10430     38.73    0.3%
 1000  1000   380     10020     19.04    0.1%
 1000  1000   400     10030     26.79    0.2%
 1000  1000   420     10450     74.31    0.7%
 1000  1000   440     10360     29.16    0.2%
 1000  1000   460     10380     56.73    0.5%
 1000  1000   480     10440     36.96    0.3%
 1000  1000   500     10310     34.71    0.3%
 1000  1000   520     10550     54.67    0.5%
 1000  1000   540     10510     34.25    0.3%
 1000  1000   560     10240     43.43    0.4%
 1000  1000   580     10530     25.81    0.2%
 1000  1000   600     10230     33.75    0.3%
 1000  1000   620     10270     47.78    0.4%
 1000  1000   640     10560     34.43    0.3%
 1000  1000   660     10570     37.01    0.3%
 1000  1000   680     10460     58.68    0.5%
 1000  1000   700     10740      50.3    0.4%
 1000  1000   720     10440     31.25    0.2%
 1000  1000   740     10590     33.65    0.3%
 1000  1000   760     10560     46.93    0.4%
 1000  1000   780     10550     46.89    0.4%
 1000  1000   800     10710     32.02    0.2%
 1000  1000   820     10570     29.45    0.2%
 1000  1000   840     10530     40.59    0.3%
 1000  1000   860     10750     39.94    0.3%
 1000  1000   880     10800     47.43    0.4%
 1000  1000   900     10870      31.2    0.2%
 1000  1000   920     10470     45.12    0.4%
 1000  1000   940     10670     45.37    0.4%
 1000  1000   960     10790     70.79    0.6%
 1000  1000   980     10700     46.76    0.4%
 1000  1000  1000     10900     61.94    0.5%

Quality and confidence:
param     error
n         0.015
m         0.015
a         0.015

Model:
Time ~=        0
    + n    9.433
    + m     0.98
    + a    0.852
              µs

Reads = 2 + (1 * n) + (0 * m) + (0 * a)
Writes = 3 + (2 * n) + (1 * m) + (1 * a)

Pallet: "pallet_uniques", Extrinsic: "mint", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Asset (r:1 w:1)
Storage: Uniques Class (r:1 w:1)
Storage: Uniques Account (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    29.88
              µs

Reads = 2
Writes = 3

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    29.88
              µs

Reads = 2
Writes = 3

Pallet: "pallet_uniques", Extrinsic: "burn", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques Asset (r:1 w:1)
Storage: Uniques Account (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    31.38
              µs

Reads = 2
Writes = 3

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    31.38
              µs

Reads = 2
Writes = 3

Pallet: "pallet_uniques", Extrinsic: "transfer", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:0)
Storage: Uniques Asset (r:1 w:1)
Storage: Uniques Account (r:0 w:2)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.25
              µs

Reads = 2
Writes = 3

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.25
              µs

Reads = 2
Writes = 3

Pallet: "pallet_uniques", Extrinsic: "redeposit", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques Asset (r:100 w:100)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + i    11.68
              µs

Reads = 1 + (1 * i)
Writes = 1 + (1 * i)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    i   mean µs  sigma µs       %
    0     14.64     0.099    0.6%
  100      1043     6.177    0.5%
  200      2110     11.18    0.5%
  300      3195     13.06    0.4%
  400      4202     9.968    0.2%
  500      5315      11.9    0.2%
  600      6442     17.23    0.2%
  700      7493     24.64    0.3%
  800      8598     39.39    0.4%
  900      9779     38.73    0.3%
 1000     10830     31.02    0.2%
 1100     11980     38.72    0.3%
 1200     13050     29.05    0.2%
 1300     14170     43.81    0.3%
 1400     15160     18.72    0.1%
 1500     16480     57.23    0.3%
 1600     17440     32.05    0.1%
 1700     18680     34.15    0.1%
 1800     19840     42.29    0.2%
 1900     20910     78.57    0.3%
 2000     22160     65.67    0.2%
 2100     23450     69.51    0.2%
 2200     24230     54.06    0.2%
 2300     25540     62.62    0.2%
 2400     26720     60.91    0.2%
 2500     27850     52.04    0.1%
 2600     29110     72.03    0.2%
 2700     30580     97.57    0.3%
 2800     31300     48.72    0.1%
 2900     32790     105.1    0.3%
 3000     33740     54.21    0.1%
 3100     35280     57.77    0.1%
 3200     36210     69.81    0.1%
 3300     37910       136    0.3%
 3400     38910     67.46    0.1%
 3500     39830     57.85    0.1%
 3600     41440     117.4    0.2%
 3700     41990     69.86    0.1%
 3800     43760     130.1    0.2%
 3900     44160     59.63    0.1%
 4000     45940     58.64    0.1%
 4100     47250     63.59    0.1%
 4200     48750     115.5    0.2%
 4300     49350     166.2    0.3%
 4400     51420     101.2    0.1%
 4500     52220     73.62    0.1%
 4600     54060      63.6    0.1%
 4700     54760     106.6    0.1%
 4800     55920     131.4    0.2%
 4900     57080     129.7    0.2%
 5000     57820     125.4    0.2%

Quality and confidence:
param     error
i         0.013

Model:
Time ~=        0
    + i    11.71
              µs

Reads = 1 + (1 * i)
Writes = 1 + (1 * i)

Pallet: "pallet_uniques", Extrinsic: "freeze", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Asset (r:1 w:1)
Storage: Uniques Class (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=     17.8
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=     17.8
              µs

Reads = 2
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "thaw", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Asset (r:1 w:1)
Storage: Uniques Class (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=     17.9
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=     17.9
              µs

Reads = 2
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "freeze_collection", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.82
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.82
              µs

Reads = 1
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "thaw_collection", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.63
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.63
              µs

Reads = 1
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "transfer_ownership", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques OwnershipAcceptance (r:1 w:1)
Storage: Uniques Class (r:1 w:1)
Storage: Uniques ClassAccount (r:0 w:2)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    20.89
              µs

Reads = 2
Writes = 4

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    20.89
              µs

Reads = 2
Writes = 4

Pallet: "pallet_uniques", Extrinsic: "set_team", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    14.34
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    14.34
              µs

Reads = 1
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "force_item_status", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques ClassAccount (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    16.35
              µs

Reads = 1
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    16.35
              µs

Reads = 1
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "set_attribute", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques InstanceMetadataOf (r:1 w:0)
Storage: Uniques Attribute (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    37.03
              µs

Reads = 3
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    37.03
              µs

Reads = 3
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "clear_attribute", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques InstanceMetadataOf (r:1 w:0)
Storage: Uniques Attribute (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    34.95
              µs

Reads = 3
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    34.95
              µs

Reads = 3
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "set_metadata", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques InstanceMetadataOf (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    28.33
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    28.33
              µs

Reads = 2
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "clear_metadata", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques InstanceMetadataOf (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    29.16
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    29.16
              µs

Reads = 2
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "set_collection_metadata", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:1)
Storage: Uniques ClassMetadataOf (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    28.24
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    28.24
              µs

Reads = 2
Writes = 2

Pallet: "pallet_uniques", Extrinsic: "clear_collection_metadata", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:0)
Storage: Uniques ClassMetadataOf (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    26.63
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    26.63
              µs

Reads = 2
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "approve_transfer", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:0)
Storage: Uniques Asset (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.93
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.93
              µs

Reads = 2
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "cancel_approval", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques Class (r:1 w:0)
Storage: Uniques Asset (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.46
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.46
              µs

Reads = 2
Writes = 1

Pallet: "pallet_uniques", Extrinsic: "set_accept_ownership", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Uniques OwnershipAcceptance (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    16.67
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    16.67
              µs

Reads = 1
Writes = 1


…--manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

@joepetrowski joepetrowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do suggestions on all because it gets a bit repetitive, but I find "items collection" awkward. Either "an item's collection", "a collection of items", or "a collection".

Comment thread frame/support/src/traits/tokens/nonfungible.rs Outdated
Comment thread frame/uniques/src/types.rs Outdated
Comment thread frame/uniques/src/types.rs Outdated
Comment thread frame/uniques/src/lib.rs Outdated
Comment thread frame/uniques/src/lib.rs Outdated
Comment thread frame/uniques/src/lib.rs Outdated
Comment thread frame/uniques/src/lib.rs Outdated
Comment thread frame/uniques/src/lib.rs Outdated
Comment thread frame/uniques/src/lib.rs Outdated
Comment thread frame/uniques/src/lib.rs Outdated
@jsidorenko

Copy link
Copy Markdown
Contributor Author

@jsidorenko please don't skip over review comments that mention a mistake :)

I'm really sorry, it was a glitch with GH UI :(

Comment thread frame/uniques/src/types.rs Outdated
Comment thread frame/uniques/src/types.rs Outdated
Comment thread frame/uniques/src/types.rs Outdated
@shawntabrizi

Copy link
Copy Markdown
Member

bot merge

@paritytech-processbot
paritytech-processbot Bot merged commit 5d3e7c4 into master May 16, 2022
@paritytech-processbot
paritytech-processbot Bot deleted the js/uniques-renamings branch May 16, 2022 13:38
godcodehunter pushed a commit to sensoriumxr/substrate that referenced this pull request Jun 22, 2022
* Rename class to collection

* Use "assets collection" instead of "asset collection"

* Rename 'instance' to 'asset'

* Change "asset `collection`" to "`collection`"

* A bit more clean up

* Rename Asset to Item

* Add a storage hack

* Typos

* fix compile

* fmt

* Fix

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* Update frame/uniques/src/lib.rs

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* Change 'items collection' to 'collection'

* Apply suggestions

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Parity Bot <admin@parity.io>
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* Rename class to collection

* Use "assets collection" instead of "asset collection"

* Rename 'instance' to 'asset'

* Change "asset `collection`" to "`collection`"

* A bit more clean up

* Rename Asset to Item

* Add a storage hack

* Typos

* fix compile

* fmt

* Fix

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* Update frame/uniques/src/lib.rs

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* Change 'items collection' to 'collection'

* Apply suggestions

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Parity Bot <admin@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Rename class to collection

* Use "assets collection" instead of "asset collection"

* Rename 'instance' to 'asset'

* Change "asset `collection`" to "`collection`"

* A bit more clean up

* Rename Asset to Item

* Add a storage hack

* Typos

* fix compile

* fmt

* Fix

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* Update frame/uniques/src/lib.rs

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* Change 'items collection' to 'collection'

* Apply suggestions

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Parity Bot <admin@parity.io>
paritytech-processbot Bot pushed a commit that referenced this pull request Apr 4, 2023
…es to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) (#13322)

* Update documentation for uniques

The documentation was outdated after merge of #11389
Using the widely spread term collections and item instead
of the previous class and instance.

* Update README.md

---------

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
Co-authored-by: Jegor Sidorenko <jegor@parity.io>
gpestana pushed a commit that referenced this pull request Apr 23, 2023
…es to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) (#13322)

* Update documentation for uniques

The documentation was outdated after merge of #11389
Using the widely spread term collections and item instead
of the previous class and instance.

* Update README.md

---------

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
Co-authored-by: Jegor Sidorenko <jegor@parity.io>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…es to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) (paritytech#13322)

* Update documentation for uniques

The documentation was outdated after merge of paritytech#11389
Using the widely spread term collections and item instead
of the previous class and instance.

* Update README.md

---------

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
Co-authored-by: Jegor Sidorenko <jegor@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants