update release wf to run linux builds on self hosted runner#1681
Conversation
WalkthroughThe release workflow updates two job runner targets — ChangesLinux Build Runner Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
23-23: ⚡ Quick winScope self-hosted runner selection to Linux-specific labels.
Line 23 and Line 175 now use a bare
self-hostedlabel. These jobs run Linux-only steps (notablyapt-getinbuild-kafka-linux), so unscoped runner matching can become flaky if additional self-hosted pools are introduced. Pinning explicit labels keeps release routing deterministic.Suggested patch
- runs-on: self-hosted + runs-on: [self-hosted, linux, x64] ... - runs-on: self-hosted + runs-on: [self-hosted, linux, x64]Also applies to: 175-175
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release.yml at line 23, The bare `self-hosted` label on the `runs-on` directives is too generic and can cause routing issues when multiple self-hosted pools exist. At line 23 (anchor) and line 175 (sibling), replace the `runs-on: self-hosted` configuration with explicit Linux-specific labels such as `[self-hosted, linux]` or equivalent labels that target your Linux self-hosted runners. This ensures the jobs that depend on Linux-only tools like `apt-get` in the build-kafka-linux step are routed deterministically to the correct runner pool.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/release.yml:
- Line 23: The bare `self-hosted` label on the `runs-on` directives is too
generic and can cause routing issues when multiple self-hosted pools exist. At
line 23 (anchor) and line 175 (sibling), replace the `runs-on: self-hosted`
configuration with explicit Linux-specific labels such as `[self-hosted, linux]`
or equivalent labels that target your Linux self-hosted runners. This ensures
the jobs that depend on Linux-only tools like `apt-get` in the build-kafka-linux
step are routed deterministically to the correct runner pool.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2b24763c-4bfc-4d10-9374-526cc36b760b
📒 Files selected for processing (1)
.github/workflows/release.yml
Summary by CodeRabbit
Release Notes
No user-facing changes in this release. This update includes internal infrastructure optimization for build processes.