Repository navigation
Add special handling for zero-length arrays to enhance PTA precision - #140
Merged
Merged
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
============================================
+ Coverage 71.91% 71.94% +0.02%
- Complexity 4354 4365 +11
============================================
Files 479 479
Lines 15856 15868 +12
Branches 2175 2179 +4
============================================
+ Hits 11403 11416 +13
- Misses 3571 3573 +2
+ Partials 882 879 -3 ☔ View full report in Codecov by Sentry. |
zhangt2333
requested changes
Feb 15, 2025
zhangt2333
left a comment
Member
There was a problem hiding this comment.
Very great optimization. Thanks for your work.
I've left some suggestions for improving the clarity of the code. Please give feedback. Finally, don't forget to rerun and update the "*-expected.txt" file.
Collaborator
Author
|
Thanks, @zhangt2333 !
|
Collaborator
Author
|
revision 2:
|
Signed-off-by: cs-cat <118669451+cs-cat@users.noreply.github.com>
zhangt2333
approved these changes
Feb 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintaining a points-to-set for components of a zero-length array is unnecessary. Use a mock object
ZeroLengthArrayto represent the zero-length array object instead.Some microbenchmarks suggest improvements in both precision and performance.
benchmark result on dacapo-2006:eclipse