Skip to content

unit toggle only affects the display of dimensions, not the input #308

Description

@PRAVEEN7230

What happened?

The problem is in wall-tool.tsx. When you draw a wall:

It captures mouse positions as building coordinates (already in meters)
The formatMeasurement function only displays the measurement in imperial format, but doesn't allow you to input in feet
There's no input field during the wall drawing process - you just click and drag to create the wall
What happens:

The displayed measurement shows 20'0" (feet format)
But the actual wall is created based on mouse cursor distance in meters
There's no way to manually enter dimensions in feet during creation or editing.

Steps to reproduce

you just click and drag to create the wall
What happens:

The displayed measurement shows 20'0" (feet format)
But the actual wall is created based on mouse cursor distance in meters
There's no way to manually enter dimensions in feet during creation

Expected behavior

the toggle unit feature should change the units in complete app inputs

Browser & OS

No response

Screenshots or screen recordings

No response

Additional context

No response

Activity

  1. Aymericr commented on Jul 19, 2026

    @Aymericr
    Contributor

    Current-state update after the recent snapping and natural-input work: the unit toggle now drives live wall length labels, and generic inspector controls accept explicit values such as 180cm or 5 ft 11 in. However, the wall drafting HUD is still display-only and there is no focused exact-length field during the two-click wall flow. Keeping this open for that concrete remaining behavior; #146 is being closed because its broader live-display and endpoint-editing requirements are now shipped.

  2. deleted a comment from on Aug 4, 2026
  3. deleted a comment from on Aug 4, 2026
  4. Aymericr commented on Aug 5, 2026

    @Aymericr
    Contributor

    Cross-link for anyone landing here first: #374 tracks the panel-by-panel migration (door/window, roof, column, slab, fence inspectors), and this issue tracks the remaining drafting gap — an exact-length field during the two-click wall flow, where the HUD is still display-only.

    The split matters because they need different work: #374 is mechanical and per-panel and is labelled help wanted; this one is an interaction change in the wall tool, so it has to land in both the 2D and 3D flows in the same PR (wiki/architecture/tools.md covers that parity requirement). #374 already links back here; adding the forward link so the pair is navigable from either side.

    Shared groundwork for both is in #321 — the measurement formatting helpers. Anyone starting on either should read those first rather than re-deriving the meters↔feet conversion.

  5. Aymericr commented on Sep 12, 2026

    @Aymericr
    Contributor

    Triage update: the old draft #602 is closed after its requested interaction changes remained outstanding and main moved on; this issue remains open and is now marked help wanted. A fresh implementation should preserve the normal drafting label until typing begins, commit with Enter, use two-stage Escape, preserve angle/junction snapping, and share behavior across the 2D and 3D wall tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or requesthelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions