fix(server): deny unknown users on every inbound channel - #482
Merged
Merged
Conversation
Jira let unmapped accounts append context onto a linked thread, and Teams started or continued a thread for anyone who could reach the bot. Both now use the same closed identity map as Discord and GitHub: an empty map or an unmapped actor cannot start, continue, stop, or approve a thread. Teams people are matched by Azure AD object id (`teamsAadObjectId`) or Bot Framework user id (`teamsUserId`). grok-4.7 / Grok harness
Unknown Jira accounts still cannot start or continue an agent thread. They can leave a context note on a thread that is already linked. grok-4.7 / Grok harness
patroza
marked this pull request as ready for review
September 23, 2026 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub, Discord, and Teams refuse anyone who is not on the identity map. They cannot start, continue, stop, or approve a T3 thread.
Jira uses the same gate for the agent. An unmapped Jira account can still leave a context note on a thread that is already linked. That note does not start or continue the agent.
Teams people are matched by
teamsAadObjectId(Azure AD object id / Graphfrom.user.id) orteamsUserId(Bot Framework29:…id). An empty map denies everyone.Test plan
grok-4.7 / Grok harness