Repository navigation
Conversation
… catches up A check one minute after a content push paged as "stuck 2525m": a mirror that is behind skipped the grace period, and the age was measured from the previous publish.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code-analysis diffPainscore total: 10484.57 → 10484.57 (0) |
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
One major watchdog gap: repeated content commits can indefinitely defer a stuck-mirror alert.
Findings
- MAJOR · .github/workflows/content-pipeline-watchdog.yml:183 · New content commits can indefinitely postpone a stuck-mirror alert
If the mirror stops publishing and mono receives publishable content commits every 30 minutes, EXPECTED is always the newest commit and EXPECTED_AT is always under 45 minutes old. This branch therefore exits within grace on every scheduled run, even though the oldest unpublished content has been stuck for hours. Start the grace clock at the oldest still-unmirrored publishable commit (or preserve when the behind state first began), so later pushes cannot reset the deadline.
Checked clean
- Pinned head and base match; reviewed the watchdog workflow and mono mirror workflow.
- The failed guard is the workflow-change gate; its deterministic backdoor scan reported clean. Other head checks were partly still running at review time.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion: did not run — claude-api_error. This review is one reviewer short.
Exact head: d6342455f7f3 · Context: repo, mono · Took 4m
| # reporting "stuck 2525m" measured from the previous publish. | ||
| STALE="the mirror is behind mono (expected \`${EXPECTED:0:7}\`, published \`${MIRRORED:0:7}\`, compare: ${FRESH})" | ||
| MIRROR_BROKEN=true | ||
| WAITING_SINCE=${EXPECTED_AT:-} |
There was a problem hiding this comment.
MAJOR: New content commits can indefinitely postpone a stuck-mirror alert
If the mirror stops publishing and mono receives publishable content commits every 30 minutes, EXPECTED is always the newest commit and EXPECTED_AT is always under 45 minutes old. This branch therefore exits within grace on every scheduled run, even though the oldest unpublished content has been stuck for hours. Start the grace clock at the oldest still-unmirrored publishable commit (or preserve when the behind state first began), so later pushes cannot reset the deadline.
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Why
On 2026-10-23 the content watchdog paged "Content is not reaching production … stuck for 2525m". Nothing was stuck. The check ran at 12:19:52 UTC, one minute after Konrad pushed content (mono 312e1fa). The mirror published it at 12:20, and production was current minutes later.
Two defects in the alert:
Change
Verified
Ran the step's script with a fake
gh:The watchdog runs on a schedule, so it uses the copy on
main: this takes effect with the next dev→main release.